Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: remoting/webapp/me2mom/host_table_entry.js

Issue 8758001: Launch Me2Me connections in a new tab. Remove OK button from post-connect screens for Me2Me. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/me2mom/host_table_entry.js
diff --git a/remoting/webapp/me2mom/host_table_entry.js b/remoting/webapp/me2mom/host_table_entry.js
index 14bb5aad6eff8def1489e47588ecf87d145e6ff3..5b65f3ee5c1ddba125c49f1b0720dec300c6ed0d 100644
--- a/remoting/webapp/me2mom/host_table_entry.js
+++ b/remoting/webapp/me2mom/host_table_entry.js
@@ -82,11 +82,16 @@ remoting.HostTableEntry.prototype.init = function(host, onRename, onDelete) {
// Create the host status cell.
var hostStatus = document.createElement('td');
if (host.status == 'ONLINE') {
+ var hostUrl = chrome.extension.getURL('choice.html') +
+ '?mode=me2me' +
+ '&hostJid=' + encodeURIComponent(host.jabberId) +
+ '&hostPublicKey=' + encodeURIComponent(host.publicKey) +
+ '&hostName=' + encodeURIComponent(host.hostName);
var connectButton = document.createElement('button');
connectButton.setAttribute('class', 'mode-select-button');
connectButton.setAttribute('type', 'button');
connectButton.setAttribute('onclick',
- 'remoting.connectHost("' + host.hostId + '")');
+ 'window.open("' + hostUrl + '", "_blank");');
connectButton.innerHTML =
chrome.i18n.getMessage(/*i18n-content*/'CONNECT_BUTTON');
hostStatus.appendChild(connectButton);
@@ -137,7 +142,7 @@ remoting.HostTableEntry.prototype.beginRename_ = function() {
var that = this;
editBox.onblur = function() { that.commitRename_(); };
- /** @param {Event} event */
+ /** @param {Event} event The keydown event. */
var onKeydown = function(event) { that.onKeydown_(event); }
editBox.onkeydown = onKeydown;
};

Powered by Google App Engine
This is Rietveld 408576698