Rename permission from input to ime.

Rename permission from input to ime.
Add a proper permission message.
Update the API to be ChromeOS only

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114181

[Zachary Kuznia, 2011-12-02 23:04:00]

Matt, could you have a look at this CL?  Thanks!

[Matt Perry, 2011-12-03 00:20:09]

lgtm

[Aaron Boodman, 2011-12-03 04:49:01]

http://codereview.chromium.org/8757015/diff/6001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8757015/diff/6001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:3933: Anything you type.
We're going to have to come up with something better than this :). We can talk
about it at the review.

http://codereview.chromium.org/8757015/diff/6001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc (right):

http://codereview.chromium.org/8757015/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc:1: //
Copyright (c) 2011 The Chromium Authors. All rights reserved.
Is there any reason to suffix the file 'chromeos'?

http://codereview.chromium.org/8757015/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc:1: //
Copyright (c) 2011 The Chromium Authors. All rights reserved.
Can we move this API out of chrome/browser/extensions? See crbug.com/101244. It
would be best if it was outside of c/b/e entirely, if there's an obvious home
for it. Otherwise, http://codereview.chromium.org/8743017/ is adding c/b/e/api,
and you can put it in a subdir of that.

[Zachary Kuznia, 2011-12-06 01:52:33]

On Sat, Dec 3, 2011 at 1:49 PM, <aa@chromium.org> wrote:

>
> http://codereview.chromium.**org/8757015/diff/6001/chrome/**
>
app/generated_resources.grd<http://codereview.chromium.org/8757015/diff/6001/chrome/app/generated_resources.grd>
> File chrome/app/generated_**resources.grd (right):
>
> http://codereview.chromium.**org/8757015/diff/6001/chrome/**
>
app/generated_resources.grd#**newcode3933<http://codereview.chromium.org/8757015/diff/6001/chrome/app/generated_resources.grd#newcode3933>
> chrome/app/generated_**resources.grd:3933: Anything you type.
> We're going to have to come up with something better than this :). We
> can talk about it at the review.
>

Sounds good.


>
> http://codereview.chromium.**org/8757015/diff/6001/chrome/**
>
browser/extensions/extension_**input_ime_apitest_chromeos.cc<http://codereview.chromium.org/8757015/diff/6001/chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc>
> File chrome/browser/extensions/**extension_input_ime_apitest_**chromeos.cc
> (right):
>
> http://codereview.chromium.**org/8757015/diff/6001/chrome/**
>
browser/extensions/extension_**input_ime_apitest_chromeos.cc#**newcode1<http://codereview.chromium.org/8757015/diff/6001/chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc#newcode1>
> chrome/browser/extensions/**extension_input_ime_apitest_**chromeos.cc:1:
> //
>
> Copyright (c) 2011 The Chromium Authors. All rights reserved.
> Is there any reason to suffix the file 'chromeos'?
>

Following the pattern of other tests that are ChromeOS only.  Is this not
done for API tests?


>
> http://codereview.chromium.**org/8757015/diff/6001/chrome/**
>
browser/extensions/extension_**input_ime_apitest_chromeos.cc#**newcode1<http://codereview.chromium.org/8757015/diff/6001/chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc#newcode1>
> chrome/browser/extensions/**extension_input_ime_apitest_**chromeos.cc:1:
> //
>
> Copyright (c) 2011 The Chromium Authors. All rights reserved.
> Can we move this API out of chrome/browser/extensions? See
> crbug.com/101244. It would be best if it was outside of c/b/e entirely,
> if there's an obvious home for it. Otherwise,
>
http://codereview.chromium.**org/8743017/<http://codereview.chromium.org/8743...
adding c/b/e/api, and you can
> put it in a subdir of that.
>

Sure.  Do you want this done in this CL, or is a separate one ok?


>
>
http://codereview.chromium.**org/8757015/<http://codereview.chromium.org/8757...
>

[Zachary Kuznia, 2011-12-12 06:50:09]

Ping

On 2011/12/06 01:52:33, Zachary Kuznia wrote:
> On Sat, Dec 3, 2011 at 1:49 PM, <mailto:aa@chromium.org> wrote:
> 
> >
> > http://codereview.chromium.**org/8757015/diff/6001/chrome/**
> >
>
app/generated_resources.grd<http://codereview.chromium.org/8757015/diff/6001/chrome/app/generated_resources.grd>
> > File chrome/app/generated_**resources.grd (right):
> >
> > http://codereview.chromium.**org/8757015/diff/6001/chrome/**
> >
>
app/generated_resources.grd#**newcode3933<http://codereview.chromium.org/8757015/diff/6001/chrome/app/generated_resources.grd#newcode3933>
> > chrome/app/generated_**resources.grd:3933: Anything you type.
> > We're going to have to come up with something better than this :). We
> > can talk about it at the review.
> >
> 
> Sounds good.
> 
> 
> >
> > http://codereview.chromium.**org/8757015/diff/6001/chrome/**
> >
>
browser/extensions/extension_**input_ime_apitest_chromeos.cc<http://codereview.chromium.org/8757015/diff/6001/chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc>
> > File chrome/browser/extensions/**extension_input_ime_apitest_**chromeos.cc
> > (right):
> >
> > http://codereview.chromium.**org/8757015/diff/6001/chrome/**
> >
>
browser/extensions/extension_**input_ime_apitest_chromeos.cc#**newcode1<http://codereview.chromium.org/8757015/diff/6001/chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc#newcode1>
> > chrome/browser/extensions/**extension_input_ime_apitest_**chromeos.cc:1:
> > //
> >
> > Copyright (c) 2011 The Chromium Authors. All rights reserved.
> > Is there any reason to suffix the file 'chromeos'?
> >
> 
> Following the pattern of other tests that are ChromeOS only.  Is this not
> done for API tests?
> 
> 
> >
> > http://codereview.chromium.**org/8757015/diff/6001/chrome/**
> >
>
browser/extensions/extension_**input_ime_apitest_chromeos.cc#**newcode1<http://codereview.chromium.org/8757015/diff/6001/chrome/browser/extensions/extension_input_ime_apitest_chromeos.cc#newcode1>
> > chrome/browser/extensions/**extension_input_ime_apitest_**chromeos.cc:1:
> > //
> >
> > Copyright (c) 2011 The Chromium Authors. All rights reserved.
> > Can we move this API out of chrome/browser/extensions? See
> > crbug.com/101244. It would be best if it was outside of c/b/e entirely,
> > if there's an obvious home for it. Otherwise,
> >
>
http://codereview.chromium.**org/8743017/%3Chttp://codereview.chromium.org/87...
> adding c/b/e/api, and you can
> > put it in a subdir of that.
> >
> 
> Sure.  Do you want this done in this CL, or is a separate one ok?
> 
> 
> >
> >
>
http://codereview.chromium.**org/8757015/%3Chttp://codereview.chromium.org/87...>
> >

[Aaron Boodman, 2011-12-12 23:42:45]

LGTM