Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 8757013: Fix pyauto-based perf test testNewTabCalendar. (Closed)

Created:
9 years ago by dennis_jeffrey
Modified:
9 years ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Fix pyauto-based perf test testNewTabCalendar. A change to the Calendar UI requires a minor modification to this test. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/test/functional/perf.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dennis_jeffrey
9 years ago (2011-12-01 02:32:39 UTC) #1
Nirnimesh
9 years ago (2011-12-01 18:37:37 UTC) #2
Lgtm

On Wednesday, November 30, 2011,  <dennisjeffrey@chromium.org> wrote:
> Reviewers: Nirnimesh,
>
> Description:
> Fix pyauto-based perf test testNewTabCalendar.
>
> A change to the Calendar UI requires a minor modification to this test.
>
> BUG=None
> TEST=None
>
>
> Please review this at http://codereview.chromium.org/8757013/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/test/functional/perf.py
>
>
> Index: chrome/test/functional/perf.py
> diff --git a/chrome/test/functional/perf.py
b/chrome/test/functional/perf.py
> index
6cb7692ff153998292f8513d3c6d0f343bf87335..35dd6617b3457ea0a991e7566ca2d3105c77ca35
100755
> --- a/chrome/test/functional/perf.py
> +++ b/chrome/test/functional/perf.py
> @@ -492,8 +492,9 @@ class LiveWebappLoadTest(BasePerfTest):
>       js = """
>           var divs = document.getElementsByTagName("div");
>           for (var i = 0; i < divs.length; ++i) {
> -            if (divs[i].hasOwnProperty("title") &&
> -                divs[i].title.indexOf("%s") == 0)
> +            if (divs[i].hasOwnProperty("dataset") &&
> +                divs[i].dataset.hasOwnProperty("tooltip") &&
> +                divs[i].dataset.tooltip.indexOf("%s") == 0)
>               window.domAutomationController.send("true");
>           }
>           window.domAutomationController.send("false");
>
>
>

-- 
../NiR

Powered by Google App Engine
This is Rietveld 408576698