Issue 8757011: Fix plugins.PluginsTest.testBlockPluginException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8757011: Fix plugins.PluginsTest.testBlockPluginException (Closed)

Created:
9 years ago by Nirnimesh

Modified:
9 years ago

Reviewers:
dennis_jeffrey

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix plugins.PluginsTest.testBlockPluginException Use a real flash url instead of local URL. Looks like exception formatting for local urls has changed or removed. R=dennisjeffrey@chromium.org BUG=105632, 100595 TEST=pyauto test: plugins.PluginsTest.testBlockPluginException Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112377

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	chrome/test/functional/PYAUTO_TESTS	View	1	4 chunks	+0 lines, -7 lines	0 comments	Download
	M	chrome/test/functional/plugins.py	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

LGTM (with 1 comment), assuming hulu is ok with this. http://codereview.chromium.org/8757011/diff/1/chrome/test/functional/PYAUTO_TESTS File chrome/test/functional/PYAUTO_TESTS (right): http://codereview.chromium.org/8757011/diff/1/chrome/test/functional/PYAUTO_TESTS#newcode171 ...

9 years ago (2011-12-01 02:09:28 UTC) #2

Nirnimesh

9 years ago (2011-12-01 02:29:21 UTC) #3

http://codereview.chromium.org/8757011/diff/1/chrome/test/functional/PYAUTO_T...
File chrome/test/functional/PYAUTO_TESTS (right):

http://codereview.chromium.org/8757011/diff/1/chrome/test/functional/PYAUTO_T...
chrome/test/functional/PYAUTO_TESTS:171: '-policy.PolicyTest.testDisable3DAPIs',
Done. Thanks

Expand Messages | Collapse Messages