Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

Issue 8757007: Implement additional UI changes for dangerous download warnings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add DCHECKs Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/download/download_shelf_context_menu_view.cc
diff --git a/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc b/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc
index f9917eb5e6265ba4abe38e338695a34e92c93f70..3bd7862c8206cd4cae6e8b624ada1bdf153ebe4d 100644
--- a/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc
+++ b/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc
@@ -21,7 +21,7 @@ DownloadShelfContextMenuView::DownloadShelfContextMenuView(
DownloadShelfContextMenuView::~DownloadShelfContextMenuView() {}
-bool DownloadShelfContextMenuView::Run(views::Widget* parent_widget,
+void DownloadShelfContextMenuView::Run(views::Widget* parent_widget,
const gfx::Rect& rect) {
views::MenuModelAdapter menu_model_adapter(GetMenuModel());
menu_runner_.reset(new views::MenuRunner(menu_model_adapter.CreateMenu()));
@@ -32,14 +32,10 @@ bool DownloadShelfContextMenuView::Run(views::Widget* parent_widget,
position = views::MenuItemView::TOPRIGHT;
else
position = views::MenuItemView::TOPLEFT;
- return menu_runner_->RunMenuAt(
+ menu_runner_->RunMenuAt(
parent_widget,
NULL,
rect,
position,
- views::MenuRunner::HAS_MNEMONICS) == views::MenuRunner::MENU_DELETED;
-}
-
-void DownloadShelfContextMenuView::Stop() {
- set_download_item(NULL);
+ views::MenuRunner::HAS_MNEMONICS);
}

Powered by Google App Engine
This is Rietveld 408576698