Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9014)

Unified Diff: chrome/service/service_utility_process_host.cc

Issue 8755002: Don't make ServiceChildProcessHost derive from ChildProcessInfo. It didn't really need to. This i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/service_child_process_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/service_utility_process_host.cc
===================================================================
--- chrome/service/service_utility_process_host.cc (revision 112096)
+++ chrome/service/service_utility_process_host.cc (working copy)
@@ -21,14 +21,14 @@
#if defined(OS_WIN)
#include "base/memory/scoped_ptr.h"
#include "base/win/scoped_handle.h"
+#include "content/common/child_process_info.h"
Scott Byer 2011/11/30 20:48:33 nit: include order
jam 2011/11/30 20:54:20 ?
#include "content/common/child_process_messages.h"
#include "printing/emf_win.h"
#endif
ServiceUtilityProcessHost::ServiceUtilityProcessHost(
Client* client, base::MessageLoopProxy* client_message_loop_proxy)
- : ServiceChildProcessHost(ChildProcessInfo::UTILITY_PROCESS),
- client_(client),
+ : client_(client),
client_message_loop_proxy_(client_message_loop_proxy),
waiting_for_reply_(false) {
process_id_ = ChildProcessInfo::GenerateChildProcessUniqueId();
@@ -95,10 +95,6 @@
bool ServiceUtilityProcessHost::StartProcess(bool no_sandbox,
const FilePath& exposed_dir) {
- // Name must be set or metrics_service will crash in any test which
- // launches a UtilityProcessHost.
- set_name(ASCIIToUTF16("utility process"));
-
if (!CreateChannel())
return false;
« no previous file with comments | « chrome/service/service_child_process_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698