Issue 8754003: Move border_contents_unittest.cc to ui/views/bubble/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8754003: Move border_contents_unittest.cc to ui/views/bubble/. (Closed)

Created:
9 years ago by msw

Modified:
9 years ago

Reviewers:
alicet1, sky

CC:
chromium-reviews, dhollowa, msw+watch_chromium.org, alicet1, tfarina, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move border_contents_unittest.cc to ui/views/bubble/. BUG=97248 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112326

Patch Set 1 #

Patch Set 2 : Sync and merge. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -253 lines)			Patch
D	chrome/browser/ui/views/bubble/border_contents_unittest.cc	View		1 chunk	+0 lines, -243 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
A +	ui/views/bubble/border_contents_unittest.cc	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	views/views.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8754003/1

9 years ago (2011-11-30 22:40:32 UTC) #5

commit-bot: I haz the power

9 years ago (2011-11-30 22:40:39 UTC) #6

Can't apply patch for file chrome/chrome_tests.gypi.
While running patch -p1 --forward --force;
patching file chrome/chrome_tests.gypi
Hunk #1 succeeded at 1872 (offset 3 lines).
Hunk #2 FAILED at 1884.
1 out of 2 hunks FAILED -- saving rejects to file chrome/chrome_tests.gypi.rej

Expand Messages | Collapse Messages