Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 8753003: Let NotificationTypeToRealModelType() handle APP_SETTINGS correctly. (Closed)

Created:
9 years ago by Nico
Modified:
9 years ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), not at google - send to devlin, Matt Perry
Visibility:
Public.

Description

Let NotificationTypeToRealModelType() handle APP_SETTINGS correctly. Change the function so that the compiler can catch problems like this in the future. BUG=none TEST=none TBR=akalin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/sync/syncable/model_type.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
Was added here: http://codereview.chromium.org/8375047/
9 years ago (2011-11-30 21:06:39 UTC) #1
not at google - send to devlin
LGTM see comment in that code review you linked to that I accidentally LGTMed due ...
9 years ago (2011-11-30 21:17:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8753003/1
9 years ago (2011-11-30 21:18:41 UTC) #3
commit-bot: I haz the power
Presubmit check for 8753003-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-11-30 21:18:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8753003/1
9 years ago (2011-11-30 21:24:14 UTC) #5
commit-bot: I haz the power
9 years ago (2011-11-30 23:38:19 UTC) #6
Change committed as 112337

Powered by Google App Engine
This is Rietveld 408576698