Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8750003: Add Popen.shell, add more subprocess2 tests and make it more compact. (Closed)

Created:
9 years ago by M-A Ruel
Modified:
9 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add Popen.shell, add more subprocess2 tests and make it more compact. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112351

Patch Set 1 #

Patch Set 2 : rebase against HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -41 lines) Patch
M subprocess2.py View 1 3 chunks +7 lines, -0 lines 0 comments Download
M tests/subprocess2_test.py View 1 8 chunks +60 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years ago (2011-11-30 20:01:48 UTC) #1
Dirk Pranke
lgtm
9 years ago (2011-11-30 21:51:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8750003/3001
9 years ago (2011-12-01 00:28:13 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-01 00:35:26 UTC) #4 
Change committed as 112351

Powered by Google App Engine
This is Rietveld 408576698