Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 8750001: Introduce a test of how much memory it takes to boot up V8. (Closed)

Created:
9 years ago by Erik Corry
Modified:
9 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Introduce a test of how much memory it takes to boot up V8. Linux only at the moment, since it uses /proc. Shows that there is room for improvement, espcially on 64 bit. Committed: http://code.google.com/p/v8/source/detail?r=10122

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -0 lines) Patch
M test/cctest/test-mark-compact.cc View 1 2 chunks +89 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years ago (2011-11-30 14:40:27 UTC) #1
Michael Starzinger
9 years ago (2011-12-01 11:44:13 UTC) #2
LGTM (with a nit). I like tests.

http://codereview.chromium.org/8750001/diff/4001/test/cctest/test-mark-compac...
File test/cctest/test-mark-compact.cc (right):

http://codereview.chromium.org/8750001/diff/4001/test/cctest/test-mark-compac...
test/cctest/test-mark-compact.cc:535: #endif
Please add an "// __linux__" comment here.

Powered by Google App Engine
This is Rietveld 408576698