Issue 8749016: Make SDCH classes IO-thread-only. Remove TSan suppression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8749016: Make SDCH classes IO-thread-only. Remove TSan suppression. (Closed)

Created:
9 years ago by Jói

Modified:
9 years ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make SDCH classes IO-thread-only. Remove TSan suppression. BUG=105579 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112677

Patch Set 1 #

Patch Set 2 : Fix Win shared compile issue. Merge to LKGR. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -12 lines)			Patch
M	chrome/browser/browser_process_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/net/sdch_dictionary_fetcher.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/net/sdch_dictionary_fetcher.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	net/base/sdch_manager.h	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	net/base/sdch_manager.cc	View		10 chunks	+16 lines, -1 line	0 comments	Download
M	tools/valgrind/tsan/suppressions.txt	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

I'm a big fan of DCHECKs when there is any doubt. :-) LGTM++

9 years ago (2011-12-01 20:37:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8749016/2001

9 years ago (2011-12-02 10:47:24 UTC) #3

Change committed as 112677

Expand Messages | Collapse Messages