The Mac accessibility impl should defer to BrowserAccessibilityManager...

The Mac accessibility impl should defer to BrowserAccessibilityManager
to determine if a node has focus, not the element's state (which goes
stale too quickly - that's how we enforce that only one element is focused
at once). That was preventing VoiceOver from notifying us when it wanted to
set focus, because it thought a node already had focus when it didn't.

BUG=105923
TEST=Use Chrome with VoiceOver, use VoiceOver navigation keys to browse focusable elements repeatedly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112343

[dmazzoni, 2011-11-30 19:32:09]

Another quickie...

[David Tseng, 2011-11-30 20:49:33]

lgtm

http://codereview.chromium.org/8749014/diff/1/content/browser/accessibility/b...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/8749014/diff/1/content/browser/accessibility/b...
content/browser/accessibility/browser_accessibility_cocoa.mm:432:
manager->GetFocus(NULL) == browserAccessibility_];
question: do we ever care that the previously focused item still has it's
focused state set?

[dmazzoni, 2011-11-30 22:02:27]

http://codereview.chromium.org/8749014/diff/1/content/browser/accessibility/b...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/8749014/diff/1/content/browser/accessibility/b...
content/browser/accessibility/browser_accessibility_cocoa.mm:432:
manager->GetFocus(NULL) == browserAccessibility_];
On 2011/11/30 20:49:33, David Tseng wrote:
> question: do we ever care that the previously focused item still has it's
> focused state set?

This change means that we're basically ignoring what state WebKit has set for an
object. BrowserAccessibilityManager keeps track of which item has focus and at
any instant in time, only one object will have the focused bit set when the AT
queries it.

[commit-bot: I haz the power, 2011-11-30 22:03:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8749014/1

[commit-bot: I haz the power, 2011-11-30 23:59:25]

Change committed as 112343