Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 8749001: Upgrade V8 Benchmark from v4 to v6. (Closed)

Created:
9 years ago by tonyg
Modified:
9 years ago
Reviewers:
cmp
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Upgrade V8 Benchmark from v4 to v6. The scores across different versions of the V8 benchmark are NOT comparable. So this will change the raw score number and expectations will need to be reset. BUG=None TEST=out/Debug/performance_ui_tests --gtest_filter=V8BenchmarkTest.Perf --run-v8-benchmark TBR=cmp Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -351 lines) Patch
M chrome/test/data/v8_benchmark/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/v8_benchmark/README.txt View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/test/data/v8_benchmark/base.js View 5 chunks +31 lines, -12 lines 0 comments Download
M chrome/test/data/v8_benchmark/crypto.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/v8_benchmark/deltablue.js View 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/test/data/v8_benchmark/earley-boyer.js View 24 chunks +26 lines, -26 lines 0 comments Download
M chrome/test/data/v8_benchmark/raytrace.js View 3 chunks +1 line, -32 lines 0 comments Download
M chrome/test/data/v8_benchmark/regexp.js View 29 chunks +369 lines, -219 lines 0 comments Download
M chrome/test/data/v8_benchmark/revisions.html View 2 chunks +23 lines, -1 line 0 comments Download
M chrome/test/data/v8_benchmark/richards.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/v8_benchmark/run.html View 6 chunks +55 lines, -18 lines 0 comments Download
M chrome/test/data/v8_benchmark/splay.js View 5 chunks +24 lines, -8 lines 0 comments Download
M chrome/test/data/v8_benchmark/style.css View 4 chunks +27 lines, -20 lines 0 comments Download
M chrome/test/data/v8_benchmark/v8-logo.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/8749001/1
9 years ago (2011-11-30 14:09:43 UTC) #1
commit-bot: I haz the power
Presubmit check for 8749001-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-11-30 14:10:27 UTC) #2
tonyg
9 years ago (2011-11-30 14:11:53 UTC) #3
cmp
9 years ago (2011-11-30 18:41:16 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698