Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 8748021: Fix file-select dialog handling for private key (pem) files. (Closed)

Created:
9 years ago by gaochun.dev
Modified:
9 years ago
CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), mihaip+watch_chromium.org
Visibility:
Public.

Description

Fix file-select dialog handling for private key (pem) files. BUG=106544 TEST=Verify that select file dialog allows selection of pem files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/options/pack_extension_overlay.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
gaochun.dev
Please review the patch, thanks.
9 years ago (2011-12-07 05:08:29 UTC) #1
gaochun.dev
Please review this patch, thanks!
9 years ago (2011-12-07 09:21:52 UTC) #2
csilv
lgtm
9 years ago (2011-12-07 18:17:24 UTC) #3
gaochun.dev
On 2011/12/07 18:17:24, csilv wrote: > lgtm Hi,csilv could you please help to commit this ...
9 years ago (2011-12-08 03:12:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gaochun.dev@gmail.com/8748021/1
9 years ago (2011-12-08 18:40:07 UTC) #5
commit-bot: I haz the power
Presubmit check for 8748021-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-08 18:40:09 UTC) #6
csilv
gaochun, Please see the link above and look at the "Legal" section. You can fill ...
9 years ago (2011-12-08 18:45:37 UTC) #7
jstritar
Drive by here... it's good to have a CL description even for trivial fixes. That ...
9 years ago (2011-12-08 18:51:29 UTC) #8
gaochun.dev
On 2011/12/08 18:45:37, csilv wrote: > gaochun, > > Please see the link above and ...
9 years ago (2011-12-09 01:42:03 UTC) #9
gaochun.dev
On 2011/12/08 18:51:29, jstritar wrote: > Drive by here... it's good to have a CL ...
9 years ago (2011-12-09 01:45:34 UTC) #10
gaochun.dev
CLA signed, pls commit again,Thanks!
9 years ago (2011-12-12 02:48:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gaochun.dev@gmail.com/8748021/1
9 years ago (2011-12-13 01:36:06 UTC) #12
commit-bot: I haz the power
9 years ago (2011-12-13 03:09:44 UTC) #13
Change committed as 114170

Powered by Google App Engine
This is Rietveld 408576698