Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 8748013: Remove a touchui section from chrome_browser.gypi (Closed)

Created:
9 years ago by bryeung
Modified:
9 years ago
CC:
chromium-reviews, Emmanuel Saint-loubert-Bié, sadrul, hashimoto
Visibility:
Public.

Description

Remove a touchui section from chrome_browser.gypi BUG=105046 TEST=grep *.ninja for relevant files in a large variety of configurations Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112640

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
bryeung
9 years ago (2011-11-30 18:18:32 UTC) #1
Emmanuel Saint-loubert-Bié
This looks good to me. My only concern is that since we have no bot ...
9 years ago (2011-11-30 18:23:50 UTC) #2
sky
LGTM
9 years ago (2011-11-30 18:25:49 UTC) #3
bryeung
On 2011/11/30 18:23:50, Emmanuel Saint-loubert wrote: > This looks good to me. My only concern ...
9 years ago (2011-11-30 18:37:51 UTC) #4
Emmanuel Saint-loubert-Bié
That makes sense. Thanks Bryan. -- Emmanuel On Wed, Nov 30, 2011 at 10:37 AM, ...
9 years ago (2011-11-30 18:43:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/8748013/1
9 years ago (2011-11-30 19:03:25 UTC) #6
commit-bot: I haz the power
Try job failure for 8748013-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-11-30 19:41:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/8748013/1
9 years ago (2011-11-30 19:43:16 UTC) #8
commit-bot: I haz the power
9 years ago (2011-11-30 21:13:05 UTC) #9
Try job failure for 8748013-1 (retry) (previous was lost) on win_rel for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698