Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 8748005: Be more willing to expand old space when evacuating new space at the end of (Closed)

Created:
9 years ago by Erik Corry
Modified:
9 years ago
CC:
v8-dev
Visibility:
Public.

Description

Be more willing to expand old space when evacuating new space at the end of a mark-sweep. We have a soft limit on old space size, which is designed to trigger an old-space collection when we hit it. Unfortunately although the soft limit had already triggered an old space collection, the soft limit was preventing objects from new space from being promoted. For every promotion candidate we were checking 3 different ways to allocate in old space before giving up and putting the object in the other semispace. This change allows the promoted objects to go to old space and also makes us more eager to sweep a page before trying other ways to find space for an object. Committed: http://code.google.com/p/v8/source/detail?r=10092

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M src/mark-compact.cc View 2 chunks +8 lines, -0 lines 1 comment Download
M src/spaces.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/spaces.cc View 2 chunks +19 lines, -16 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years ago (2011-11-30 10:20:55 UTC) #1
Vyacheslav Egorov (Chromium)
9 years ago (2011-11-30 10:34:43 UTC) #2
lgtm

http://codereview.chromium.org/8748005/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/8748005/diff/1/src/mark-compact.cc#newcode2568
src/mark-compact.cc:2568: if (maybe_result->IsFailure()) {
I don't think you need this. (also you can move Expand back to the private
section).

Powered by Google App Engine
This is Rietveld 408576698