Issue 8748004: More accurate EXIF parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8748004: More accurate EXIF parsing (Closed)

Created:
9 years ago by Vladislav Kaznacheev

Modified:
9 years ago

Reviewers:
dgozman, SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

More accurate EXIF parsing Better handling for less common situations when there is no EXIF section and the SOF section is far from the file start. BUG=chromium-os:22838 TEST=Load the images attached to the bug into the Photo Editor, observe the thumbnails. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112206

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -164 lines)			Patch
	M	chrome/browser/resources/file_manager/js/byte_reader.js	View		5 chunks	+15 lines, -6 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/js/exif_parser.js	View		2 chunks	+156 lines, -158 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8748004/1

9 years ago (2011-11-30 12:07:48 UTC) #3

Change committed as 112206

Expand Messages | Collapse Messages