Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: ui/views/controls/textfield/textfield.h

Issue 8748001: Make text input type and password visibility bit independent in Textfield (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move IsPassword() back to .cc Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield.h
diff --git a/ui/views/controls/textfield/textfield.h b/ui/views/controls/textfield/textfield.h
index 5ff542d563771b9022b67e6c47d5ae5d57b7068f..5f4b0317680fe9690e518d79cb734a0b7ad74954 100644
--- a/ui/views/controls/textfield/textfield.h
+++ b/ui/views/controls/textfield/textfield.h
@@ -63,12 +63,9 @@ class VIEWS_EXPORT Textfield : public View {
bool read_only() const { return read_only_; }
void SetReadOnly(bool read_only);
- // Gets/Sets whether or not this Textfield is a password field.
- // TODO(bryeung): Currently this is only used in
- // chrome/browser/chromeos/options/wifi_config_view.cc, which is being
- // converted to WebUI. Please remove this when that happens.
+ // Gets whether or not this Textfield is a password field. This property
+ // can be set by calling SetTextInputType.
bool IsPassword() const;
- void SetPassword(bool password);
// Gets/Sets the input type of this textfield.
ui::TextInputType GetTextInputType() const;

Powered by Google App Engine
This is Rietveld 408576698