Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: chrome/browser/chromeos/options/wifi_config_view.cc

Issue 8748001: Make text input type and password visibility bit independent in Textfield (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move IsPassword() back to .cc Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/options/wifi_config_view.cc
diff --git a/chrome/browser/chromeos/options/wifi_config_view.cc b/chrome/browser/chromeos/options/wifi_config_view.cc
index 31f84c18683fdbed5dfa11d8e3730c4460d26748..f5eec93ce50bbc5cb60d8202ab215fd23c20e0c5 100644
--- a/chrome/browser/chromeos/options/wifi_config_view.cc
+++ b/chrome/browser/chromeos/options/wifi_config_view.cc
@@ -501,9 +501,10 @@ void WifiConfigView::ButtonPressed(views::Button* sender,
const views::Event& event) {
if (sender == passphrase_visible_button_) {
if (passphrase_textfield_) {
- passphrase_textfield_->SetPassword(!passphrase_textfield_->IsPassword());
- passphrase_visible_button_->SetToggled(
- !passphrase_textfield_->IsPassword());
+ bool censor = !passphrase_textfield_->IsPassword();
+ passphrase_textfield_->SetTextInputType(
+ censor ? ui::TEXT_INPUT_TYPE_PASSWORD : ui::TEXT_INPUT_TYPE_TEXT);
+ passphrase_visible_button_->SetToggled(!censor);
}
} else {
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698