Make text input type and password visibility bit independent in Textfield

ui/views/controls/textfield/textfield.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #define UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #pragma once
 
 #include "build/build_config.h"
 
@@ skipping 29 matching lines @@
 class TextfieldController;
 
 // This class implements a View that wraps a native text (edit) field.
 class VIEWS_EXPORT Textfield : public View {
  public:
   // The button's class name.
   static const char kViewClassName[];
 
   enum StyleFlags {
     STYLE_DEFAULT   = 0,
-    STYLE_PASSWORD  = 1 << 0,
+    STYLE_OBSCURED  = 1 << 0,
     STYLE_LOWERCASE = 1 << 1
   };
 
+  // The initial text input type is set to TEXT_INPUT_TYPE_PASSWORD
+  // if STYLE_OBSCURED is set in |style|. Otherwise it is set to
+  // TEXT_INPUT_TYPE_TEXT.
   Textfield();
   explicit Textfield(StyleFlags style);

[benrg, 2011/12/07 19:17:47]

Is it worth adding TextInputType as a second argument to this constructor,
instead of guessing it?

   virtual ~Textfield();
 
   // TextfieldController accessors
   void SetController(TextfieldController* controller);
   TextfieldController* GetController() const;
 
   // Gets/Sets whether or not the Textfield is read-only.
   bool read_only() const { return read_only_; }
   void SetReadOnly(bool read_only);
 
-  // Gets/Sets whether or not this Textfield is a password field.
-  // TODO(bryeung): Currently this is only used in
+  // Gets/sets the STYLE_OBSCURED bit, controlling whether characters in this
+  // Textfield are displayed as asterisks/bullets. This does not affect the
+  // text input type.
+  // TODO(bryeung): Currently SetObscured is only used in
   // chrome/browser/chromeos/options/wifi_config_view.cc, which is being
-  // converted to WebUI.  Please remove this when that happens.
-  bool IsPassword() const;
-  void SetPassword(bool password);
+  // converted to WebUI.  Please remove it when that happens.
+  bool IsObscured() const;
+  void SetObscured(bool obscured);
 
-  // Gets/Sets the input type of this textfield.
+  // Gets/Sets the input type of this textfield. TEXT_INPUT_TYPE_PASSWORD
+  // disables the virtual keyboard and IME, but does not hide the text (use

[bryeung, 2011/12/07 19:33:15]

it does not disable the virtual keyboard, just the IME

[benrg, 2011/12/07 21:33:20]

Changed. I misinterpreted Peng's comment.

+  // STYLE_OBSCURED for that).
   ui::TextInputType GetTextInputType() const;
   void SetTextInputType(ui::TextInputType type);
 
   // Gets/Sets the text currently displayed in the Textfield.
   const string16& text() const { return text_; }
 
   // Sets the text currently displayed in the Textfield.  This doesn't
   // change the cursor position if the current cursor is within the
   // new text's range, or moves the cursor to the end if the cursor is
   // out of the new text's range.
@@ skipping 222 matching lines @@
 
   // The input type of this text field.
   ui::TextInputType text_input_type_;
 
   DISALLOW_COPY_AND_ASSIGN(Textfield);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_