Make text input type and password visibility bit independent in Textfield

ui/views/controls/textfield/textfield.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #if defined(TOOLKIT_USES_GTK)
 #include <gdk/gdkkeysyms.h>
 #endif
 
@@ skipping 55 matching lines @@
       read_only_(false),
       default_width_in_chars_(0),
       draw_border_(true),
       text_color_(SK_ColorBLACK),
       use_default_text_color_(true),
       background_color_(SK_ColorWHITE),
       use_default_background_color_(true),
       initialized_(false),
       horizontal_margins_were_set_(false),
       vertical_margins_were_set_(false),
-      text_input_type_(ui::TEXT_INPUT_TYPE_TEXT) {
+      text_input_type_(style & STYLE_PASSWORD ?

[bryeung, 2011/12/02 16:22:28]

I'd rather not duplicate the logic of IsPassword here.

[benrg, 2011/12/02 18:21:41]

I did it that way to avoid calling a method while in violation of a class
invariant, but it turns out the invariant wasn't supposed to hold anyway...

+          ui::TEXT_INPUT_TYPE_PASSWORD : ui::TEXT_INPUT_TYPE_TEXT) {
   set_focusable(true);
-  if (IsPassword())
-    SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
 }
 
 Textfield::~Textfield() {
 }
 
 void Textfield::SetController(TextfieldController* controller) {
   controller_ = controller;
 }
 
 TextfieldController* Textfield::GetController() const {
   return controller_;
 }
 
 void Textfield::SetReadOnly(bool read_only) {
   read_only_ = read_only;
   if (native_wrapper_) {
     native_wrapper_->UpdateReadOnly();
     native_wrapper_->UpdateTextColor();
     native_wrapper_->UpdateBackgroundColor();
   }
 }
 
 bool Textfield::IsPassword() const {
   return style_ & STYLE_PASSWORD;
 }
 
-void Textfield::SetPassword(bool password) {
-  if (password) {
-    style_ = static_cast<StyleFlags>(style_ | STYLE_PASSWORD);
-    SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
-  } else {
-    style_ = static_cast<StyleFlags>(style_ & ~STYLE_PASSWORD);
-    SetTextInputType(ui::TEXT_INPUT_TYPE_TEXT);
-  }
-  if (native_wrapper_)
-    native_wrapper_->UpdateIsPassword();
-}
-
-
 ui::TextInputType Textfield::GetTextInputType() const {
   if (read_only() || !IsEnabled())
     return ui::TEXT_INPUT_TYPE_NONE;
   return text_input_type_;
 }
 
 void Textfield::SetTextInputType(ui::TextInputType type) {
+  bool was_password = IsPassword();
+  bool will_be_password = type == ui::TEXT_INPUT_TYPE_PASSWORD;
   text_input_type_ = type;
-  bool should_be_password = type == ui::TEXT_INPUT_TYPE_PASSWORD;
-  if (IsPassword() != should_be_password)
-    SetPassword(should_be_password);
+  if (was_password != will_be_password) {
+    style_ = static_cast<StyleFlags>(style_ ^ STYLE_PASSWORD);
+    if (native_wrapper_)
+      native_wrapper_->UpdateIsPassword();
+  }
 }
 
 void Textfield::SetText(const string16& text) {
   text_ = text;
   if (native_wrapper_)
     native_wrapper_->UpdateText();
 }
 
 void Textfield::AppendText(const string16& text) {
   text_ += text;
@@ skipping 304 matching lines @@
     }
 #endif
   }
 }
 
 std::string Textfield::GetClassName() const {
   return kViewClassName;
 }
 
 }  // namespace views