Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.h

Issue 8747015: Apply per-tab preference after RenderViewImpl creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added test Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/tab_contents/per_tab_prefs_tab_helper_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_ 5 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
6 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_ 6 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 virtual void DidBecomeSelected() OVERRIDE; 228 virtual void DidBecomeSelected() OVERRIDE;
229 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 229 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
230 virtual void TabContentsDestroyed(TabContents* tab) OVERRIDE; 230 virtual void TabContentsDestroyed(TabContents* tab) OVERRIDE;
231 231
232 // content::NotificationObserver overrides: 232 // content::NotificationObserver overrides:
233 virtual void Observe(int type, 233 virtual void Observe(int type,
234 const content::NotificationSource& source, 234 const content::NotificationSource& source,
235 const content::NotificationDetails& details) OVERRIDE; 235 const content::NotificationDetails& details) OVERRIDE;
236 236
237 private: 237 private:
238 friend class PerTabPrefsTabHelper; // for UpdateWebPreferences
239 FRIEND_TEST_ALL_PREFIXES(
240 PerTabPrefsTabHelperTest, OverridePrefsOnViewCreation);
241
238 // Internal helpers ---------------------------------------------------------- 242 // Internal helpers ----------------------------------------------------------
239 243
240 // Message handlers. 244 // Message handlers.
241 void OnSnapshot(const SkBitmap& bitmap); 245 void OnSnapshot(const SkBitmap& bitmap);
242 void OnPDFHasUnsupportedFeature(); 246 void OnPDFHasUnsupportedFeature();
243 247
244 // Returns the server that can provide alternate error pages. If the returned 248 // Returns the server that can provide alternate error pages. If the returned
245 // URL is empty, the default error page built into WebKit will be used. 249 // URL is empty, the default error page built into WebKit will be used.
246 GURL GetAlternateErrorPageURL() const; 250 GURL GetAlternateErrorPageURL() const;
247 251
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 342
339 // The supporting objects need to outlive the TabContents dtor (as they may 343 // The supporting objects need to outlive the TabContents dtor (as they may
340 // be called upon during its execution). As a result, this must come last 344 // be called upon during its execution). As a result, this must come last
341 // in the list. 345 // in the list.
342 scoped_ptr<TabContents> tab_contents_; 346 scoped_ptr<TabContents> tab_contents_;
343 347
344 DISALLOW_COPY_AND_ASSIGN(TabContentsWrapper); 348 DISALLOW_COPY_AND_ASSIGN(TabContentsWrapper);
345 }; 349 };
346 350
347 #endif // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_ 351 #endif // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/tab_contents/per_tab_prefs_tab_helper_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698