Dispatch IndexedDB IPC messages to worker threads

content/common/child_thread.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/child_thread.h"
 
 #include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/process.h"
 #include "base/process_util.h"
 #include "base/string_util.h"
 #include "base/tracked_objects.h"
 #include "content/common/child_process.h"
 #include "content/common/child_process_messages.h"
 #include "content/common/child_trace_message_filter.h"
 #include "content/common/file_system/file_system_dispatcher.h"
+#include "content/common/indexed_db_message_filter.h"
 #include "content/common/quota_dispatcher.h"
 #include "content/common/resource_dispatcher.h"
 #include "content/common/socket_stream_dispatcher.h"
 #include "content/public/common/content_switches.h"
 #include "ipc/ipc_logging.h"
 #include "ipc/ipc_sync_channel.h"
 #include "ipc/ipc_sync_message_filter.h"
 #include "ipc/ipc_switches.h"
 #include "webkit/glue/webkit_glue.h"
 
@@ skipping 26 matching lines @@
 
   resource_dispatcher_.reset(new ResourceDispatcher(this));
   socket_stream_dispatcher_.reset(new SocketStreamDispatcher());
   file_system_dispatcher_.reset(new FileSystemDispatcher());
   quota_dispatcher_.reset(new QuotaDispatcher());
 
   sync_message_filter_ =
       new IPC::SyncMessageFilter(ChildProcess::current()->GetShutDownEvent());
   channel_->AddFilter(sync_message_filter_.get());
   channel_->AddFilter(new ChildTraceMessageFilter());
+
+  idb_message_filter_ = new IndexedDBMessageFilter;
+  channel_->AddFilter(idb_message_filter_.get());

[michaeln, 2011/12/14 02:15:53]

The data member isn't used, would it work to just add the filter and not hang on
to a reference in this class (as is done for ChildTraceMessageFilter).
Alternatively, I'm not sure why the SyncMessageFilter is explicitly removed,
maybe this filter should also be explicitly removed in the dtor?

[dgrogan, 2011/12/15 02:47:44]

Yes, this works, it causes the ipc channel to be the only owner.  So the
IDBMessageFilter is deleted when the ipc channel is.  Which seems to happen for
the utility process (when this was in child_thread), but the filter isn't
deleted in the renderer process.  I think I disabled sudden termination but I
couldn't get RenderThreadImpl's dtor to run.  I looked to the Audio filters as a
control and they were also not deleted.
I'm also not sure why SyncMessageFilter is explicitly removed, but
ChildTraceMessageFilter was explicitly removed until jam said it didn't need to
be, albeit indirectly:

http://codereview.chromium.org/6694004/diff2/6017:17001/content/common/child_...
http://codereview.chromium.org/6694004/diff2/6017:17001/content/common/child_...

 }
 
 ChildThread::~ChildThread() {
 #ifdef IPC_MESSAGE_LOG_ENABLED
   IPC::Logging::GetInstance()->SetIPCSender(NULL);
 #endif
 
   channel_->RemoveFilter(sync_message_filter_.get());
 
   // Close this channel before resetting the message loop attached to it so
@@ skipping 190 matching lines @@
     MessageLoop::current()->Quit();
     return;
   }
 
   // The child process shutdown sequence is a request response based mechanism,
   // where we send out an initial feeler request to the child process host
   // instance in the browser to verify if it's ok to shutdown the child process.
   // The browser then sends back a response if it's ok to shutdown.
   Send(new ChildProcessHostMsg_ShutdownRequest);
 }