Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: ui/views/controls/textfield/textfield_views_model.h

Issue 8747001: Reintroduce password support to NativeTextfieldViews (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: delete more dead code, address recent comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield_views_model.h
diff --git a/ui/views/controls/textfield/textfield_views_model.h b/ui/views/controls/textfield/textfield_views_model.h
index ce1d88fdac8a95140f1e9b2d8cfb05f94726e3de..da36fe5bfdda5775dce4dbdc69c9e7a182f38de5 100644
--- a/ui/views/controls/textfield/textfield_views_model.h
+++ b/ui/views/controls/textfield/textfield_views_model.h
@@ -65,10 +65,6 @@ class VIEWS_EXPORT TextfieldViewsModel {
explicit TextfieldViewsModel(Delegate* delegate);
virtual ~TextfieldViewsModel();
- void set_is_password(bool is_password) {
- is_password_ = is_password;
- }
-
// Edit related methods.
const string16& GetText() const;
@@ -182,10 +178,6 @@ class VIEWS_EXPORT TextfieldViewsModel {
// Redo edit. Returns true if redo changed the text.
bool Redo();
- // Returns visible text. If the field is password, it returns the
- // sequence of "*".
- string16 GetVisibleText() const;
-
// Cuts the currently selected text and puts it to clipboard. Returns true
// if text has changed after cutting.
bool Cut();
@@ -249,9 +241,6 @@ class VIEWS_EXPORT TextfieldViewsModel {
FRIEND_TEST_ALL_PREFIXES(TextfieldViewsModelTest, UndoRedo_CutCopyPasteTest);
FRIEND_TEST_ALL_PREFIXES(TextfieldViewsModelTest, UndoRedo_ReplaceTest);
- // Returns the visible text given |start| and |end|.
- string16 GetVisibleText(size_t start, size_t end) const;
-
// Insert the given |text|. |mergeable| indicates if this insert
// operation can be merged to previous edit in the edit history.
void InsertTextInternal(const string16& text, bool mergeable);
@@ -302,9 +291,6 @@ class VIEWS_EXPORT TextfieldViewsModel {
// The stylized text, cursor, selection, and the visual layout model.
scoped_ptr<gfx::RenderText> render_text_;
- // True if the text is the password.
- bool is_password_;
-
typedef std::list<internal::Edit*> EditHistory;
EditHistory edit_history_;

Powered by Google App Engine
This is Rietveld 408576698