Reintroduce password support to NativeTextfieldViews

ui/gfx/render_text_linux.cc

Index: ui/gfx/render_text_linux.cc
diff --git a/ui/gfx/render_text_linux.cc b/ui/gfx/render_text_linux.cc
index e2f0d67b9294737cea244a7c11954c8515134553..3905b0f371e348e2fce0e0aeecb5c20785840b16 100644
--- a/ui/gfx/render_text_linux.cc
+++ b/ui/gfx/render_text_linux.cc
@@ -234,7 +234,7 @@ void RenderTextLinux::EnsureLayout() {
     layout_ = pango_cairo_create_layout(cr);
     SetupPangoLayout(
         layout_,
-        text(),
+        GetCensoredText(),
         default_style().font,
         display_rect().width(),
         base::i18n::GetFirstStrongCharacterDirection(text()),

[msw, 2011/12/03 00:22:40]

We should test this behavior with RTL passwords.

[benrg, 2011/12/08 21:40:55]

What this is intended to do is display the whole *** field RTL if the password
is (or starts out) RTL. Would always LTR be better? Matching the LTR/RTL ranges
of the unobscured text would be possible but rather difficult...

@@ -468,7 +468,8 @@ SelectionModel RenderTextLinux::RightSelectionModel(
 
 SelectionModel RenderTextLinux::LeftSelectionModelByWord(
     const SelectionModel& selection) {
-  base::i18n::BreakIterator iter(text(), base::i18n::BreakIterator::BREAK_WORD);
+  string16 txt = GetCensoredText();
+  base::i18n::BreakIterator iter(txt, base::i18n::BreakIterator::BREAK_WORD);
   bool success = iter.Init();
   DCHECK(success);
   if (!success)
@@ -497,7 +498,8 @@ SelectionModel RenderTextLinux::LeftSelectionModelByWord(
 
 SelectionModel RenderTextLinux::RightSelectionModelByWord(
     const SelectionModel& selection) {
-  base::i18n::BreakIterator iter(text(), base::i18n::BreakIterator::BREAK_WORD);
+  string16 txt = GetCensoredText();
+  base::i18n::BreakIterator iter(txt, base::i18n::BreakIterator::BREAK_WORD);
   bool success = iter.Init();
   DCHECK(success);
   if (!success)