Reintroduce password support to NativeTextfieldViews

ui/views/controls/textfield/native_textfield_views_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 491 matching lines @@
   InitTextfield(Textfield::STYLE_PASSWORD);
 
   EXPECT_EQ(ui::TEXT_INPUT_TYPE_PASSWORD, GetTextInputType());
 
   last_contents_.clear();
   textfield_->SetText(ASCIIToUTF16("my password"));
   // Just to make sure the text() and callback returns
   // the actual text instead of "*".
   EXPECT_STR_EQ("my password", textfield_->text());
   EXPECT_TRUE(last_contents_.empty());
+
+  // Cut and copy should be disabled in the context menu.
+  model_->SelectAll();
+  EXPECT_FALSE(IsCommandIdEnabled(IDS_APP_CUT));
+  EXPECT_FALSE(IsCommandIdEnabled(IDS_APP_COPY));

[oshima, 2011/12/02 23:15:54]

can you also add ctrl-c/ctrl-x?

[benrg, 2011/12/06 17:21:30]

Done.

 }
 
 TEST_F(NativeTextfieldViewsTest, InputTypeSetsPassword) {
   InitTextfield(Textfield::STYLE_DEFAULT);
 
   // Defaults to TEXT
   EXPECT_EQ(ui::TEXT_INPUT_TYPE_TEXT, GetTextInputType());
 
   // Setting to passwords also sets password state of textfield.
   textfield_->SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
@@ skipping 293 matching lines @@
   // Ensure that disabled textfields do not support drag operations.
   textfield_->SetEnabled(false);
   EXPECT_EQ(ui::DragDropTypes::DRAG_NONE,
             textfield_view_->GetDragOperationsForView(NULL, kStringPoint));
   textfield_->SetEnabled(true);
   // Ensure that textfields without selections do not support drag operations.
   textfield_->ClearSelection();
   EXPECT_EQ(ui::DragDropTypes::DRAG_NONE,
             textfield_view_->GetDragOperationsForView(NULL, kStringPoint));
   textfield_->SelectRange(kStringRange);
+  // Ensure that password textfields do not support drag operations.
+  textfield_->SetIsPassword(true);
+  EXPECT_EQ(ui::DragDropTypes::DRAG_NONE,
+            textfield_view_->GetDragOperationsForView(NULL, kStringPoint));
+  textfield_->SetIsPassword(false);
   // Ensure that textfields only initiate drag operations inside the selection.
   EXPECT_EQ(ui::DragDropTypes::DRAG_NONE,
             textfield_view_->GetDragOperationsForView(NULL, gfx::Point()));
   EXPECT_FALSE(textfield_view_->CanStartDragForView(NULL, gfx::Point(),
                                                     gfx::Point()));
   EXPECT_EQ(ui::DragDropTypes::DRAG_COPY,
             textfield_view_->GetDragOperationsForView(NULL, kStringPoint));
   EXPECT_TRUE(textfield_view_->CanStartDragForView(NULL, kStringPoint,
                                                    gfx::Point()));
   // Ensure that textfields support local moves.
@@ skipping 730 matching lines @@
 #else
   EXPECT_EQ(500U, textfield_->GetCursorPosition());
 #endif
 #endif  // !defined(OS_WIN)
 
   // Reset locale.
   base::i18n::SetICUDefaultLocale(locale);
 }
 
 }  // namespace views