Issue 8746022: Split accessible bounds calculation into two methods for Mac & Win

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8746022: Split accessible bounds calculation into two methods for Mac & Win (Closed)

Created:
9 years ago by dmazzoni

Modified:
9 years ago

Reviewers:
David Tseng

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, davidbarr+watch_chromium.org, jam, yuzo+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Split accessible bounds calculation into two methods, one to retrieve the local bounds for Mac, and one to retrieve the global bounds for Windows. This fixes a problem where VoiceOver was showing the incorrect bounds when the window is scrolled. BUG=105906 TEST=manual testing with VoiceOver. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112344

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -16 lines)			Patch
M	content/browser/accessibility/browser_accessibility.h	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	content/browser/accessibility/browser_accessibility.cc	View		2 chunks	+13 lines, -7 lines	0 comments	Download
M	content/browser/accessibility/browser_accessibility_cocoa.mm	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	content/browser/accessibility/browser_accessibility_win.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8746022/1004

9 years ago (2011-11-30 22:04:02 UTC) #3

Change committed as 112344

Expand Messages | Collapse Messages