Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 8746020: Fixed a header name error in UMA statistics that record what servers accept range requests. (Closed)

Created:
9 years ago by ahendrickson
Modified:
9 years ago
CC:
chromium-reviews, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fixed a header name error in UMA statistics that record what servers accept range requests. Change the names of the statistics, so that there is no pollution of the data. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112302

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed variable name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M content/browser/download/download_resource_handler.h View 1 1 chunk +8 lines, -5 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/download/download_stats.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_stats.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahendrickson
PTAL.
9 years ago (2011-11-30 16:31:33 UTC) #1
Randy Smith (Not in Mondays)
LGTM, but I don't think it's safe to commit without Chris' ok; he knows the ...
9 years ago (2011-11-30 18:49:27 UTC) #2
cbentzel
LGTM Have you tried this locally? http://codereview.chromium.org/8746020/diff/1/content/browser/download/download_resource_handler.cc File content/browser/download/download_resource_handler.cc (right): http://codereview.chromium.org/8746020/diff/1/content/browser/download/download_resource_handler.cc#newcode133 content/browser/download/download_resource_handler.cc:133: &accepts_ranges_)) { Nit: ...
9 years ago (2011-11-30 18:51:01 UTC) #3
ahendrickson
On 2011/11/30 18:51:01, cbentzel wrote: > LGTM > > Have you tried this locally? > ...
9 years ago (2011-11-30 19:33:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahendrickson@chromium.org/8746020/1005
9 years ago (2011-11-30 20:07:47 UTC) #5
commit-bot: I haz the power
9 years ago (2011-11-30 21:59:08 UTC) #6
Change committed as 112302

Powered by Google App Engine
This is Rietveld 408576698