Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 8746018: Only make function literals in top-level object literals pretenured and constant function propert... (Closed)

Created:
9 years ago by fschneider
Modified:
9 years ago
CC:
v8-dev
Visibility:
Public.

Description

Only make function literals in top-level object literals pretenured and constant function properties. This change is a refinement of http://code.google.com/p/v8/source/detail?r=7283. Making all function literals inside object literals constant function properties causes us to lose map sharing. This hurts code where many object literals are created. The idea is that top-level code is mostly executed once and functions inside top-level object literals remain fast with this change. BUG=v8:1795 Committed: http://code.google.com/p/v8/source/detail?r=10096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/parser.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years ago (2011-11-30 15:00:23 UTC) #1
Vyacheslav Egorov (Chromium)
9 years ago (2011-11-30 15:02:59 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698