Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 8746007: ntp string cleanse (Closed)

Created:
9 years ago by Evan Stade
Modified:
9 years ago
Reviewers:
csilv, Rick Byers
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

ntp string cleanse remove unused strings, and in one case start using an unused string (most visited delete tooltip) a couple of the strings may still used by touch ntp and in the bookmarks pane, but both of these are getting removed quite soon BUG=none TEST=compile and visual inspection Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112366

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -103 lines) Patch
M chrome/app/generated_resources.grd View 3 chunks +0 lines, -64 lines 0 comments Download
M chrome/browser/resources/ntp4/most_visited_page.js View 2 chunks +4 lines, -0 lines 2 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 4 chunks +2 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
9 years ago (2011-11-30 06:35:46 UTC) #1
Rick Byers
LGTM with nit Note that I didn't actually verify each of the strings you removed ...
9 years ago (2011-11-30 15:16:07 UTC) #2
csilv
lgtm
9 years ago (2011-11-30 18:30:27 UTC) #3
Evan Stade
http://codereview.chromium.org/8746007/diff/1/chrome/browser/resources/ntp4/most_visited_page.js File chrome/browser/resources/ntp4/most_visited_page.js (right): http://codereview.chromium.org/8746007/diff/1/chrome/browser/resources/ntp4/most_visited_page.js#newcode66 chrome/browser/resources/ntp4/most_visited_page.js:66: templateData.removethumbnailtooltip; On 2011/11/30 15:16:07, Rick Byers wrote: > Nit: ...
9 years ago (2011-11-30 22:47:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8746007/1
9 years ago (2011-11-30 22:47:41 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-01 01:14:35 UTC) #6
Change committed as 112366

Powered by Google App Engine
This is Rietveld 408576698