Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 8746006: Remove IDS_MOZC macro. (Closed)

Created:
9 years ago by mazda
Modified:
9 years ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove IDS_MOZC macro. BUG=chromium-os:23574 TEST=Ran check_grd_for_unused_strings.py and checked these resource IDs are not reported. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -48 lines) Patch
M chrome/browser/chromeos/language_preferences.cc View 4 chunks +44 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mazda
9 years ago (2011-11-30 06:25:21 UTC) #1
Yusuke Sato
LGTM
9 years ago (2011-11-30 06:29:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8746006/1
9 years ago (2011-11-30 06:37:30 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
9 years ago (2011-11-30 08:22:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8746006/1
9 years ago (2011-11-30 08:23:33 UTC) #5
commit-bot: I haz the power
9 years ago (2011-11-30 09:45:45 UTC) #6
Change committed as 112180

Powered by Google App Engine
This is Rietveld 408576698