Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 8746003: Expand android tests. (Closed)

Created:
9 years ago by John Grabowski
Modified:
9 years ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Expand android tests. Add net_unittests to baseline build/run; add some test disabling. Add experimental build phase to bot script. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -5 lines) Patch
M build/all_android.gyp View 2 chunks +11 lines, -3 lines 0 comments Download
M build/android/buildbot.sh View 1 chunk +13 lines, -0 lines 0 comments Download
A build/android/gtest_filter/net_unittests_disabled View 1 chunk +52 lines, -0 lines 0 comments Download
M build/android/run_tests.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
John Grabowski
9 years ago (2011-11-30 04:55:28 UTC) #1
michaelbai
LGTM, if the disabled net unittests are not emulator specific.
9 years ago (2011-11-30 18:05:46 UTC) #2
John Grabowski
9 years ago (2011-11-30 18:11:41 UTC) #3
On 2011/11/30 18:05:46, michaelbai wrote:
> LGTM, if the disabled net unittests are not emulator specific.

No idea if they are or are not.  Short term, get it up.  Longer term, resolve.

Powered by Google App Engine
This is Rietveld 408576698