Use OAuth2 refresh token to download GAIA info

Use OAuth2 refresh token to download GAIA info

We currently use client login to download GAIA info. Unfortunately the client login token expires after 24 hours.

To fix this we now use a OAuth2 refresh token to create a new access token each time we download GAIA info.

BUG=91241
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112214

[Ivan Korotkov, 2011-11-30 11:17:31]

Please make sure that linux_chromeos and linux_chromeos_clang trybots pass.

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_downloader.cc (right):

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader.cc:37: // Template for optional
authorization header when using client login access
the ClientLogin

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader.cc:220: registrar_.Add(this,
We subscribe for notifications for both methods (refresh token & ClientLogin),
is it ok?

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader.cc:341: void
ProfileDownloader::OnGetTokenSuccess(const std::string& access_token) {
I'm kinda puzzled, when does this get called? When using OAuth refresh token
method, right? Do we get a notification with Observe() for it?
Also, shouldn't we remove the notification subscription here?

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_downloader_delegate.h (right):

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader_delegate.h:30: // Checks if we should
use a OAuth refresh token. Currently this is only used
Better actually: "Whether we should use an OAuth refresh token or the Picasa
token from ClientLogin. The latter is currently used in ChromeOS."

[Ivan Korotkov, 2011-11-30 11:27:18]

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_downloader_delegate.h (right):

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader_delegate.h:32: virtual bool
GetShouldUseOAuthRefreshToken() = 0;
Rename to ShouldUseOAuthRefreshToken?

[sail, 2011-11-30 11:34:10]

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_downloader.cc (right):

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader.cc:37: // Template for optional
authorization header when using client login access
On 2011/11/30 11:17:31, Ivan Korotkov wrote:
> the ClientLogin

Done.

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader.cc:220: registrar_.Add(this,
On 2011/11/30 11:17:31, Ivan Korotkov wrote:
> We subscribe for notifications for both methods (refresh token & ClientLogin),
> is it ok?

Yea, the same notification is sent for both.

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader.cc:341: void
ProfileDownloader::OnGetTokenSuccess(const std::string& access_token) {
On 2011/11/30 11:17:31, Ivan Korotkov wrote:
> I'm kinda puzzled, when does this get called? When using OAuth refresh token
> method, right? Do we get a notification with Observe() for it?
> Also, shouldn't we remove the notification subscription here?

This is a callback for the oauth2_access_token_fetcher. This class is the
delegate for the fetcher so there's nothing to unset. I added comments to
explain this.

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_downloader_delegate.h (right):

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader_delegate.h:30: // Checks if we should
use a OAuth refresh token. Currently this is only used
On 2011/11/30 11:17:31, Ivan Korotkov wrote:
> Better actually: "Whether we should use an OAuth refresh token or the Picasa
> token from ClientLogin. The latter is currently used in ChromeOS."

Done.

http://codereview.chromium.org/8746002/diff/1001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_downloader_delegate.h:32: virtual bool
GetShouldUseOAuthRefreshToken() = 0;
On 2011/11/30 11:27:18, Ivan Korotkov wrote:
> Rename to ShouldUseOAuthRefreshToken?

Done.

[Ivan Korotkov, 2011-11-30 11:56:37]

LGTM

[commit-bot: I haz the power, 2011-11-30 12:37:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8746002/41

[commit-bot: I haz the power, 2011-11-30 13:55:36]

Change committed as 112214