Rebase ConfirmBubble on the new views bubble.

Rebase ConfirmBubble on the new views bubble.

Win SpellingBubble is accessible via textfield context menu:
"Spell-checker options"->"Ask Google..."

BUG=98323, 99130
TEST=ConfirmBubble (SpellingBubble) works as before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112261

[msw, 2011-11-30 05:19:13]

Please take a look; thanks!

[Hironori Bono, 2011-11-30 05:30:03]

Greetings,

Thank you for your change. It looks good in general, is it possible to leave the
gfx::NativeView parameter in ConfirmBubble::Show() because it is needed by its
Mac implementation: <http://codereview.chromium.org/8697001/>?

Regards,

Hironori Bono

http://codereview.chromium.org/8746001/diff/1/chrome/browser/ui/confirm_bubbl...
File chrome/browser/ui/confirm_bubble_model.h (right):

http://codereview.chromium.org/8746001/diff/1/chrome/browser/ui/confirm_bubbl...
chrome/browser/ui/confirm_bubble_model.h:69: static void Show(const gfx::Point&
origin, ConfirmBubbleModel* model);
Mac needs gfx::NativeView to create an NSView. Is it possible to add
gfx::NativeView even though it is not used by views?

[alicet1, 2011-11-30 06:15:36]

lgtm

bubbles api related change looks ok.

[msw, 2011-11-30 06:51:38]

Updated; thanks for the tip! Please take another look.

http://codereview.chromium.org/8746001/diff/1/chrome/browser/ui/confirm_bubbl...
File chrome/browser/ui/confirm_bubble_model.h (right):

http://codereview.chromium.org/8746001/diff/1/chrome/browser/ui/confirm_bubbl...
chrome/browser/ui/confirm_bubble_model.h:69: static void Show(const gfx::Point&
origin, ConfirmBubbleModel* model);
On 2011/11/30 05:30:03, Hironori Bono wrote:
> Mac needs gfx::NativeView to create an NSView. Is it possible to add
> gfx::NativeView even though it is not used by views?

Done.

[Hironori Bono, 2011-11-30 06:54:07]

LGTM.
Thank you so much for your quick update. :)

Regards,

Hironori Bono

[msw, 2011-11-30 07:12:53]

+Ben for OWNERS approval.

[Ben Goodger (Google), 2011-11-30 15:42:22]

lgtm

[commit-bot: I haz the power, 2011-11-30 17:51:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/8746001/2002

[commit-bot: I haz the power, 2011-11-30 19:12:21]

Change committed as 112261