Issue 8746: Linux fixes for the WebKit merge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8746: Linux fixes for the WebKit merge. (Closed)

Created:
12 years, 1 month ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, dglazkov, sgk

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Linux fixes for the WebKit merge.

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -4 lines)			Patch
M	webkit/SConscript.port	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/build/V8Bindings/SConscript	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/build/WebCore/SConscript	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/build/port/SConscript	View	3 chunks	+1 line, -2 lines	0 comments	Download
M	webkit/port/platform/GKURL_unittest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Evan Martin

Still compiling it on top of trunk, but I think it's good.

12 years, 1 month ago (2008-10-30 19:01:28 UTC) #1

Evan Martin

+sgk as an FYI changelist. I tried to also get changes that are needed on ...

12 years, 1 month ago (2008-10-30 19:10:37 UTC) #2

sgk

lgtm i'll follow up with the Windows side after you get a chance to submit

12 years, 1 month ago (2008-10-30 19:12:47 UTC) #3

tony

12 years, 1 month ago (2008-10-30 19:16:02 UTC) #4

lgtm2!

On 2008/10/30 19:12:47, sgk wrote:
> lgtm
> 
> i'll follow up with the Windows side after you get a chance to submit