Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 8745019: Heapchecker: Remove a suppression since the leak has been fixed. (Closed)

Created:
9 years ago by Lei Zhang
Modified:
9 years ago
Reviewers:
cbentzel
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Heapchecker: Remove a suppression since the leak has been fixed. BUG=104760 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
9 years ago (2011-11-30 19:27:34 UTC) #1
cbentzel
9 years ago (2011-11-30 19:28:30 UTC) #2
LGTM

On Wed, Nov 30, 2011 at 2:27 PM, <thestig@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Description:
> Heapchecker: Remove a suppression since the leak has been fixed.
>
> BUG=104760
> TEST=none
>
> Please review this at
http://codereview.chromium.**org/8745019/<http://codereview.chromium.org/8745...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     tools/heapcheck/suppressions.**txt
>
>
> Index: tools/heapcheck/suppressions.**txt
> ==============================**==============================**=======
> --- tools/heapcheck/suppressions.**txt    (revision 112264)
> +++ tools/heapcheck/suppressions.**txt    (working copy)
> @@ -1711,27 +1711,6 @@
>    fun:chromeos::::**GViewRequestInterceptorTest::**SetUp
>  }
>  {
> -   bug_104760
> -   Heapcheck:Leak
> -   fun:g_malloc
> -   fun:g_slice_alloc
> -   fun:g_datalist_id_set_data_**full
> -   fun:g_object_set_data
> -   fun:views::NativeWidgetGtk::**RegisterChildExposeHandler
> -   fun:views::NativeViewHostGtk::**NativeViewAttached
> -   fun:views::NativeViewHost::**Attach
> -   fun:**NativeTabContentsContainerGtk:**:AttachContents
> -   fun:TabContentsContainer::**ChangeTabContents
> -   fun:ConstrainedHtmlDelegateGtk
> -   fun:ConstrainedHtmlUI::**CreateConstrainedHtmlDialog
> -   fun:printing::**PrintPreviewTabController::**CreatePrintPreviewTab
> -   fun:printing::**PrintPreviewTabController::**GetOrCreatePreviewTab
> -#   fun:PrintPreviewHandlerTest_**StickyMarginsCustomThenDefault**
> _Test::TestBody
> -#   fun:**PrintPreviewTabControllerUnitT**est_GetOrCreatePreviewTab_**
> Test::TestBody
> -#   fun:**PrintPreviewTabControllerUnitT**est_MultiplePreviewTabs_Test::*
> *TestBody
> -#   fun:**PrintPreviewTabControllerUnitT**est_ClearInitiatorTabDetails_**
> Test::TestBody
> -}
> -{
>    bug_105624_a
>    Heapcheck:Leak
>    fun:PeerConnectionHandlerTest_**Basic_Test::TestBody
>
>
>

Powered by Google App Engine
This is Rietveld 408576698