Disambiguate origins of tasks posted by the WebDataService.

Disambiguate origins of tasks posted by the WebDataService.

When calling PostTask, rather than always providing the source information corresponding to ScheduleTask, use the location of the caller of ScheduleTask. This helps in disambiguating tasks in, for example, the task profiler.


BUG=105921
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113032

[erikwright (departed), 2011-11-30 17:55:33]

Hi Scott,

I'm in the process of diagnosing a performance issue with initial requests. This
CL improves the diagnostics we receive from the Task Profiler regarding tasks of
the WebDataService. Rather than all tasks having the same 'FROM_HERE' location
of ScheduleTask, make the location a parameter to ScheduleTask and thereby log
the caller of that method (which is what we need to identify the specific task
posted).

Thanks,

Erik

[sky, 2011-11-30 17:59:58]

Please update BUG= appropriate. If there is no bug on this, it's worth creating
one.

http://codereview.chromium.org/8745017/diff/1/chrome/browser/webdata/web_data...
File chrome/browser/webdata/web_data_service.cc (right):

http://codereview.chromium.org/8745017/diff/1/chrome/browser/webdata/web_data...
chrome/browser/webdata/web_data_service.cc:743: const tracked_objects::Location&
from_here, const base::Closure& task) {
nit: each param on own line.

http://codereview.chromium.org/8745017/diff/1/chrome/browser/webdata/web_data...
File chrome/browser/webdata/web_data_service.h (right):

http://codereview.chromium.org/8745017/diff/1/chrome/browser/webdata/web_data...
chrome/browser/webdata/web_data_service.h:596: const tracked_objects::Location&
from_here, const base::Closure& task);
nit: when you wrap, each param on its own line.

[sky, 2011-11-30 18:00:16]

LGTM

[commit-bot: I haz the power, 2011-11-30 19:23:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/8745017/3004

[erikwright (departed), 2011-11-30 20:13:54]

http://codereview.chromium.org/8745017/diff/1/chrome/browser/webdata/web_data...
File chrome/browser/webdata/web_data_service.cc (right):

http://codereview.chromium.org/8745017/diff/1/chrome/browser/webdata/web_data...
chrome/browser/webdata/web_data_service.cc:743: const tracked_objects::Location&
from_here, const base::Closure& task) {
On 2011/11/30 17:59:58, sky wrote:
> nit: each param on own line.

Done.

http://codereview.chromium.org/8745017/diff/1/chrome/browser/webdata/web_data...
File chrome/browser/webdata/web_data_service.h (right):

http://codereview.chromium.org/8745017/diff/1/chrome/browser/webdata/web_data...
chrome/browser/webdata/web_data_service.h:596: const tracked_objects::Location&
from_here, const base::Closure& task);
On 2011/11/30 17:59:58, sky wrote:
> nit: when you wrap, each param on its own line.

Done.

[commit-bot: I haz the power, 2011-11-30 20:18:47]

Try job failure for 8745017-3004 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-11-30 20:32:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/8745017/3004

[commit-bot: I haz the power, 2011-11-30 23:18:36]

Try job failure for 8745017-3004 (previous was lost) (retry) on win_rel for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-12-01 17:25:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/8745017/3004

[commit-bot: I haz the power, 2011-12-01 18:10:13]

Try job failure for 8745017-3004 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-12-05 19:00:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/8745017/14001

[commit-bot: I haz the power, 2011-12-05 21:31:31]

Change committed as 113032