Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 8745016: Fix reference to potentially NULL TabContentsWrapper. (Closed)

Created:
9 years ago by dominich
Modified:
9 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Fix reference to potentially NULL TabContentsWrapper. BUG=105689 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112705

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adding comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dominich
9 years ago (2011-11-30 16:55:18 UTC) #1
Peter Kasting
LGTM http://codereview.chromium.org/8745016/diff/1/chrome/browser/autocomplete/autocomplete_edit.cc File chrome/browser/autocomplete/autocomplete_edit.cc (right): http://codereview.chromium.org/8745016/diff/1/chrome/browser/autocomplete/autocomplete_edit.cc#newcode1039 chrome/browser/autocomplete/autocomplete_edit.cc:1039: } else { Nit: While here... no else ...
9 years ago (2011-12-01 21:03:37 UTC) #2
dominich
http://codereview.chromium.org/8745016/diff/1/chrome/browser/autocomplete/autocomplete_edit.cc File chrome/browser/autocomplete/autocomplete_edit.cc (right): http://codereview.chromium.org/8745016/diff/1/chrome/browser/autocomplete/autocomplete_edit.cc#newcode1039 chrome/browser/autocomplete/autocomplete_edit.cc:1039: } else { On 2011/12/01 21:03:38, Peter Kasting wrote: ...
9 years ago (2011-12-02 00:30:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/8745016/5001
9 years ago (2011-12-02 14:35:42 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-02 15:46:50 UTC) #5
Change committed as 112705

Powered by Google App Engine
This is Rietveld 408576698