[filebrowser] Support renaming in Gallery.

[filebrowser] Support renaming in Gallery.

BUG=chromium-os:23434, chromium-os:23435
TEST=See bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112462

[dgozman, 2011-11-30 13:25:41]

Aaron, Erik, Jon,
Could you please approve the change to
chrome/browser/extensions/extension_file_browser_private_api.cc?

Vlad, please review this.

Thanks,
Dmitry

[Vladislav Kaznacheev, 2011-12-01 10:34:09]

http://codereview.chromium.org/8745013/diff/3001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right):

http://codereview.chromium.org/8745013/diff/3001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/gallery.js:231:
self.filenameEdit_.value = ImageUtil.getFileNameFromUrl(selectedURL);
Did you forget to add image_util.js?

http://codereview.chromium.org/8745013/diff/3001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/gallery.js:297: return;
I think we should check for existing file name, we would not have a chance to do
it later.

http://codereview.chromium.org/8745013/diff/3001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/gallery.js:891: name =
name.substr(Ribbon.Item.COPY_SIGNATURE.length);
This would not work nicely. If you do not want to append a number at the end
please write a TODO for that.

[dgozman, 2011-12-01 11:34:05]

http://codereview.chromium.org/8745013/diff/3001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right):

http://codereview.chromium.org/8745013/diff/3001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/gallery.js:231:
self.filenameEdit_.value = ImageUtil.getFileNameFromUrl(selectedURL);
On 2011/12/01 10:34:09, Vladislav Kaznacheev wrote:
> Did you forget to add image_util.js?

Whoops. Added.

http://codereview.chromium.org/8745013/diff/3001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/gallery.js:297: return;
On 2011/12/01 10:34:09, Vladislav Kaznacheev wrote:
> I think we should check for existing file name, we would not have a chance to
do
> it later.

Done.

http://codereview.chromium.org/8745013/diff/3001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/image_editor/gallery.js:891: name =
name.substr(Ribbon.Item.COPY_SIGNATURE.length);
On 2011/12/01 10:34:09, Vladislav Kaznacheev wrote:
> This would not work nicely. If you do not want to append a number at the end
> please write a TODO for that.

Done.

[Vladislav Kaznacheev, 2011-12-01 12:14:44]

lgtm

[commit-bot: I haz the power, 2011-12-01 12:33:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/8745013/8001

[commit-bot: I haz the power, 2011-12-01 14:36:02]

Change committed as 112462