Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1827)

Issue 8745012: MIPS: Implement crankshaft support for nested object literals. (Closed)

Created:
9 years ago by kalmard
Modified:
9 years ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Implement crankshaft support for nested object literals. Port r10061 (c648e1d1) Original commit message: This generates optimized code for deep-copying of nested object literal boilerplates which are statically known. Most of the boilerplates have already been generated at crankshaft time, so this optimization should kick in for virtually every object literal. Only nested object literal graphs up to a certain depth and containing up to a certain total number of properties are considered for this optimization. This will prevent explosion of code size due to large object literals (e.g. eval on JSON). Improves splay performance because object literals are created often. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -7 lines) Patch
M src/mips/lithium-codegen-mips.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +68 lines, -1 line 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +12 lines, -4 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kalmard
Fully building and testing v8 on MIPS requires the following patches to be landed: http://codereview.chromium.org/8561001/ ...
9 years ago (2011-11-30 14:00:13 UTC) #1
Michael Starzinger
9 years ago (2011-12-01 14:33:30 UTC) #2
LGTM. Rebased. Landed as r10128.

Powered by Google App Engine
This is Rietveld 408576698