Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 8744011: WebSocket Pepper API: minor properties implementation (Closed)

Created:
9 years ago by Takashi Toyoshima
Modified:
9 years ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

WebSocket Pepper API: minor properties implementation - GetURL() - GetProtocol() BUG=87310 TEST=ui_tests --gtest_filter='PPAPITest.WebSocket*' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112422

Patch Set 1 #

Patch Set 2 : Add unit tests for GetURL() #

Patch Set 3 : ready for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -49 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/tests/test_websocket.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/tests/test_websocket.cc View 1 2 6 chunks +78 lines, -41 lines 0 comments Download
M webkit/plugins/ppapi/ppb_websocket_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_websocket_impl.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Takashi Toyoshima
Sorry for many review requests, but could you review this change, too?
9 years ago (2011-11-30 14:41:26 UTC) #1
Takashi Toyoshima
I added piman@ and viettrungluu@ as a OWNERS' reviewer, too.
9 years ago (2011-12-01 04:40:11 UTC) #2
piman
lgtm
9 years ago (2011-12-01 05:01:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8744011/5001
9 years ago (2011-12-01 06:28:02 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-01 07:44:14 UTC) #5
Change committed as 112422

Powered by Google App Engine
This is Rietveld 408576698