Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 8744009: Do not execute IME tests when USE_VIRTUAL_KEYBOARD is defined (Closed)

Created:
9 years ago by Yusuke Sato
Modified:
9 years ago
Reviewers:
mazda
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Do not execute IME tests when USE_VIRTUAL_KEYBOARD is defined. Most of keyboard layouts are not yet supported for the configuration. BUG=chromium-os:23067 TEST=ran try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112216

Patch Set 1 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/chromeos/system_key_event_listener_browsertest.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
9 years ago (2011-11-30 10:08:51 UTC) #1
mazda
lgtm
9 years ago (2011-11-30 10:14:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8744009/1002
9 years ago (2011-11-30 12:59:51 UTC) #3
commit-bot: I haz the power
9 years ago (2011-11-30 13:56:47 UTC) #4
Change committed as 112216

Powered by Google App Engine
This is Rietveld 408576698