Separate Authenticator and Session unittests.

remoting/protocol/fake_session.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_FAKE_SESSION_H_
 #define REMOTING_PROTOCOL_FAKE_SESSION_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "net/base/completion_callback.h"
 #include "net/socket/socket.h"
 #include "net/socket/stream_socket.h"
 #include "remoting/protocol/session.h"
 
 class MessageLoop;
 
 namespace remoting {
 namespace protocol {
 
 extern const char kTestJid[];
 
 // FakeSocket implement net::Socket interface for FakeConnection. All data
 // written to FakeSocket is stored in a buffer returned by written_data().
 // Read() reads data from another buffer that can be set with AppendInputData().
 // Pending reads are supported, so if there is a pending read AppendInputData()
 // calls the read callback.
+//
+// Two fake sockets can be connected to each other using the SetPeer()
+// method, e.g.:
+//   a->SetPeer(b);
+//   b->SetPeer(a);

[Wez, 2011/12/13 00:12:38]

nit: You could actually have SetPeer() set the peer relationship in both
directions pretty easily... ;)

[Sergey Ulanov, 2011/12/13 02:31:55]

Done.

+// After this all data written to |a| can be read from |b| and vica
+// versa. Two connected sockets |a| and |b| must be created and used on the
+// same thread.
+//
 class FakeSocket : public net::StreamSocket {
  public:
   FakeSocket();
   virtual ~FakeSocket();
 
   const std::string& written_data() const { return written_data_; }
 
-  void AppendInputData(const char* data, int data_size);
+  void AppendInputData(const std::vector<char>& data);
+  void SetPeer(FakeSocket* peer_socket);
   int input_pos() const { return input_pos_; }
   bool read_pending() const { return read_pending_; }
 
   // net::Socket implementation.

[Wez, 2011/12/13 00:12:38]

nit: I prefer "interface" to "implementation"; the comment indicates that these
methods are from a particular interface.

[Sergey Ulanov, 2011/12/13 02:31:55]

Done.

   virtual int Read(net::IOBuffer* buf, int buf_len,
                    const net::CompletionCallback& callback) OVERRIDE;
   virtual int Write(net::IOBuffer* buf, int buf_len,
                     const net::CompletionCallback& callback) OVERRIDE;
 
   virtual bool SetReceiveBufferSize(int32 size) OVERRIDE;
   virtual bool SetSendBufferSize(int32 size) OVERRIDE;
 
   // net::StreamSocket implementation.
   virtual int Connect(const net::CompletionCallback& callback) OVERRIDE;
   virtual void Disconnect() OVERRIDE;
   virtual bool IsConnected() const OVERRIDE;
   virtual bool IsConnectedAndIdle() const OVERRIDE;
   virtual int GetPeerAddress(net::AddressList* address) const OVERRIDE;
   virtual int GetLocalAddress(net::IPEndPoint* address) const OVERRIDE;
   virtual const net::BoundNetLog& NetLog() const OVERRIDE;
   virtual void SetSubresourceSpeculation() OVERRIDE;
   virtual void SetOmniboxSpeculation() OVERRIDE;
   virtual bool WasEverUsed() const OVERRIDE;
   virtual bool UsingTCPFastOpen() const OVERRIDE;
   virtual int64 NumBytesRead() const OVERRIDE;
   virtual base::TimeDelta GetConnectTimeMicros() const OVERRIDE;
 
  private:
   bool read_pending_;
   scoped_refptr<net::IOBuffer> read_buffer_;
   int read_buffer_size_;
   net::CompletionCallback read_callback_;
+  base::WeakPtr<FakeSocket> peer_socket_;
 
   std::string written_data_;
   std::string input_data_;
   int input_pos_;
 
   net::BoundNetLog net_log_;
 
   MessageLoop* message_loop_;
+  base::WeakPtrFactory<FakeSocket> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeSocket);
 };
 
 // FakeUdpSocket is similar to FakeSocket but behaves as UDP socket. All written
 // packets are stored separetely in written_packets(). AppendInputPacket() adds
 // one packet that will be returned by Read().
 class FakeUdpSocket : public net::Socket {
  public:
   FakeUdpSocket();
@@ skipping 85 matching lines @@
   Session::Error error_;
   bool closed_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeSession);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_FAKE_SESSION_H_