Issue 8743021: GTK: Move to gtk_widget_get_allocation() for some of chrome/browser/ui/gtk/

Issue 8743021: GTK: Move to gtk_widget_get_allocation() for some of chrome/browser/ui/gtk/ (Closed)

Created:
9 years ago by Elliot Glaysher

Modified:
9 years ago

Reviewers:
Evan Stade

CC:
chromium-reviews, robert.bradford

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

GTK: Move to gtk_widget_get_allocation() for some of chrome/browser/ui/gtk/ BUG=79722 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112518

Patch Set 2 : comment nit #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -44 lines)			Patch
M	chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc	View		7 chunks	+25 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_toolbar_gtk.cc	View		4 chunks	+20 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/gtk/custom_button.h	View	1	1 chunk	+2 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/gtk/custom_button.cc	View		3 chunks	+11 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm http://codereview.chromium.org/8743021/diff/1/chrome/browser/ui/gtk/custom_button.h File chrome/browser/ui/gtk/custom_button.h (right): http://codereview.chromium.org/8743021/diff/1/chrome/browser/ui/gtk/custom_button.h#newcode172 chrome/browser/ui/gtk/custom_button.h:172: // Returns the dimensions of the widget's allocation. ...

9 years ago (2011-11-30 23:02:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8743021/5001

9 years ago (2011-11-30 23:30:41 UTC) #3

commit-bot: I haz the power

Try job failure for 8743021-5001 (retry) on mac_rel for step "compile" (clobber build). It's a ...

9 years ago (2011-12-01 00:16:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8743021/5001

9 years ago (2011-12-01 18:57:39 UTC) #5

Change committed as 112518

Expand Messages | Collapse Messages