This includes the Chrome 16 release notes.

This includes the Chrome 16 release notes.
It also includes updates to the manifest doc
to include the requirements field
which the release notes reference.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114051

[kathyw, 2011-11-30 21:46:15]

Nice work! Going through all the CLs must have been very very fun (not).

I have a few nitpicky comments.

In general, your descriptions are lengthier than mine. This might be good or
bad. My philosophy was to make the descriptions as small as possible (usually
one sentence), leaving the details to the linked-to doc. For example, I wouldn't
have included the second sentence of the chrome.tabs.update() item. It's a
tradeoff between readability and helpfulness...

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/static/whats_new.html (right):

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:34: <a
href="webNavigation.html">webNavigation API</a>
I haven't been consistent about this, but I think it's best to use an English
name for the API. (The optional permissions API is the one that's convincing me
of this. :) So:

-> "web navigation API"

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:53: <a
href="contentSettings.html">contentSettings API</a>
contentSettings -> content settings

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:64: <a
href="manifest.html">requirements</a> field
This item isn't very helpful. We should either delete it for now or give a more
specific link and/or rewrite this to be more informative. Perhaps add a little
example, such as:

For example, you might use this field to specify that your app requires Web GL.

[or whatever makes sense instead of "Web GL"]

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:77: This method has replaced
the deprecated methods
I'd delete the second sentence, since the deprecation is already covered by
another item.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:91: You can now specify the
supported locales for an external extension
specify -> limit?

(that way it's clear that this is optional and just restricts locales)

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:92: by adding the
<code>supported_locales</code> attribute(s)
Remove "(s)". We try to avoid it, and I'm pretty sure singular is good (or good
enough) here.

Add a link to where this is documented. Maybe:

an <a href="external_extensions.html">external extension</a>

[By the way... if you search for "supported_locale" in that page, you can see
that it's misspelled once, and the whole paragraph could use a copyedit. Oops.]

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:95: simply leave out this
attribute.
I'd delete this sentence. Save it for the real docs.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:101: <li>The methods
<code>getAllInWindow</code> and
getAllInWindow -> getAllInWindow()

(use () after method names)

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:102:
<code>getSelected</code> have been deprecated.
getSelected -> getSelected()

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:104: <a
href="tabs.html#method-query">chrome.tabs.query {‘windowId’: windowID}</a>.
This isn't standard syntax. How about:

<a href="tabs.html#method-query">chrome.tabs.query()</a> with the argument
<code>{‘windowId’: windowID}</code>.

also,  change the curly quote to straight quotes.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:106: <a
href="tabs.html#method-query">chrome.tabs.query {‘active’: true}</a>.
Same change as the previous one, perhaps without the link.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:119: The “experimental”
permission is no longer required
Change to straight quotes. We usually use straight quotes even where curly
quotes might be correct.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:121: <a
href="windows.html#type-Window">window “panel”</a> type.
Again, change to straight quotes.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:122: By default, the “panel’
type creates a popup
change to straight double-quotes.

(currently, they're curly and mismatched)

[mkearney, 2011-11-30 21:54:34]

Thanks - I will action these.

Also, I totally know what you mean about shortening descriptions. I chose
to go for the longer descriptions, as I am still learning this stuff, and I
wanted to make sure I got the right gist in the note. I figured it is
always easier to delete once the good reviewers like yourself are happy
that the information is accurate.

I will now shorten as much as I can.

Meggin

On Wed, Nov 30, 2011 at 1:46 PM, <kathyw@chromium.org> wrote:

> Nice work! Going through all the CLs must have been very very fun (not).
>
> I have a few nitpicky comments.
>
> In general, your descriptions are lengthier than mine. This might be good
> or
> bad. My philosophy was to make the descriptions as small as possible
> (usually
> one sentence), leaving the details to the linked-to doc. For example, I
> wouldn't
> have included the second sentence of the chrome.tabs.update() item. It's a
> tradeoff between readability and helpfulness...
>
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html>
> File chrome/common/extensions/docs/**static/whats_new.html (right):
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode34<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode34>
> chrome/common/extensions/docs/**static/whats_new.html:34: <a
> href="webNavigation.html">**webNavigation API</a>
> I haven't been consistent about this, but I think it's best to use an
> English name for the API. (The optional permissions API is the one
> that's convincing me of this. :) So:
>
> -> "web navigation API"
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode53<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode53>
> chrome/common/extensions/docs/**static/whats_new.html:53: <a
> href="contentSettings.html">**contentSettings API</a>
> contentSettings -> content settings
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode64<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode64>
> chrome/common/extensions/docs/**static/whats_new.html:64: <a
> href="manifest.html">**requirements</a> field
> This item isn't very helpful. We should either delete it for now or give
> a more specific link and/or rewrite this to be more informative. Perhaps
> add a little example, such as:
>
> For example, you might use this field to specify that your app requires
> Web GL.
>
> [or whatever makes sense instead of "Web GL"]
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode77<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode77>
> chrome/common/extensions/docs/**static/whats_new.html:77: This method has
> replaced the deprecated methods
> I'd delete the second sentence, since the deprecation is already covered
> by another item.
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode91<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode91>
> chrome/common/extensions/docs/**static/whats_new.html:91: You can now
> specify the supported locales for an external extension
> specify -> limit?
>
> (that way it's clear that this is optional and just restricts locales)
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode92<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode92>
> chrome/common/extensions/docs/**static/whats_new.html:92: by adding the
> <code>supported_locales</code> attribute(s)
> Remove "(s)". We try to avoid it, and I'm pretty sure singular is good
> (or good enough) here.
>
> Add a link to where this is documented. Maybe:
>
> an <a href="external_extensions.**html">external extension</a>
>
> [By the way... if you search for "supported_locale" in that page, you
> can see that it's misspelled once, and the whole paragraph could use a
> copyedit. Oops.]
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode95<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode95>
> chrome/common/extensions/docs/**static/whats_new.html:95: simply leave out
> this attribute.
> I'd delete this sentence. Save it for the real docs.
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode101<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode101>
> chrome/common/extensions/docs/**static/whats_new.html:101: <li>The methods
> <code>getAllInWindow</code> and
> getAllInWindow -> getAllInWindow()
>
> (use () after method names)
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode102<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode102>
> chrome/common/extensions/docs/**static/whats_new.html:102:
> <code>getSelected</code> have been deprecated.
> getSelected -> getSelected()
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode104<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode104>
> chrome/common/extensions/docs/**static/whats_new.html:104: <a
> href="tabs.html#method-query">**chrome.tabs.query {‘windowId’:
> windowID}</a>.
> This isn't standard syntax. How about:
>
> <a href="tabs.html#method-query">**chrome.tabs.query()</a> with the
> argument <code>{‘windowId’: windowID}</code>.
>
> also,  change the curly quote to straight quotes.
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode106<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode106>
> chrome/common/extensions/docs/**static/whats_new.html:106: <a
> href="tabs.html#method-query">**chrome.tabs.query {‘active’: true}</a>.
> Same change as the previous one, perhaps without the link.
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode119<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode119>
> chrome/common/extensions/docs/**static/whats_new.html:119: The
> “experimental” permission is no longer required
> Change to straight quotes. We usually use straight quotes even where
> curly quotes might be correct.
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode121<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode121>
> chrome/common/extensions/docs/**static/whats_new.html:121: <a
> href="windows.html#type-**Window">window “panel”</a> type.
> Again, change to straight quotes.
>
> http://codereview.chromium.**org/8743020/diff/2001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode122<http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/docs/static/whats_new.html#newcode122>
> chrome/common/extensions/docs/**static/whats_new.html:122: By default, the
> “panel’ type creates a popup
> change to straight double-quotes.
>
> (currently, they're curly and mismatched)
>
>
http://codereview.chromium.**org/8743020/<http://codereview.chromium.org/8743...
>

[mkearney, 2011-11-30 23:39:51]

Second version includes updates based on Kathy's review.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/static/whats_new.html (right):

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:34: <a
href="webNavigation.html">webNavigation API</a>
On 2011/11/30 21:46:15, kathyw wrote:
> I haven't been consistent about this, but I think it's best to use an English
> name for the API. (The optional permissions API is the one that's convincing
me
> of this. :) So:
> 
> -> "web navigation API"

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:53: <a
href="contentSettings.html">contentSettings API</a>
On 2011/11/30 21:46:15, kathyw wrote:
> contentSettings -> content settings

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:64: <a
href="manifest.html">requirements</a> field
I chose to keep this in for the short term until we hear back from developers
about whether or not we need to document it. If we don't hear back, I will just
delete the whole thing, but for now, I figure no harm in giving it an extra day
or two. 

Also, I reworded it a little bit and included example.

On 2011/11/30 21:46:15, kathyw wrote:
> This item isn't very helpful. We should either delete it for now or give a
more
> specific link and/or rewrite this to be more informative. Perhaps add a little
> example, such as:
> 
> For example, you might use this field to specify that your app requires Web
GL.
> 
> [or whatever makes sense instead of "Web GL"]

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:77: This method has replaced
the deprecated methods
On 2011/11/30 21:46:15, kathyw wrote:
> I'd delete the second sentence, since the deprecation is already covered by
> another item.

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:91: You can now specify the
supported locales for an external extension
On 2011/11/30 21:46:15, kathyw wrote:
> specify -> limit?
> 
> (that way it's clear that this is optional and just restricts locales)

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:92: by adding the
<code>supported_locales</code> attribute(s)
I've implemented your changes. Also, I added to the top of my to-do list to
revise the external_extensions.html page.

On 2011/11/30 21:46:15, kathyw wrote:
> Remove "(s)". We try to avoid it, and I'm pretty sure singular is good (or
good
> enough) here.
> 
> Add a link to where this is documented. Maybe:
> 
> an <a href="external_extensions.html">external extension</a>
> 
> [By the way... if you search for "supported_locale" in that page, you can see
> that it's misspelled once, and the whole paragraph could use a copyedit.
Oops.]

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:95: simply leave out this
attribute.
On 2011/11/30 21:46:15, kathyw wrote:
> I'd delete this sentence. Save it for the real docs.

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:101: <li>The methods
<code>getAllInWindow</code> and
On 2011/11/30 21:46:15, kathyw wrote:
> getAllInWindow -> getAllInWindow()
> 
> (use () after method names)

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:102:
<code>getSelected</code> have been deprecated.
On 2011/11/30 21:46:15, kathyw wrote:
> getSelected -> getSelected()

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:104: <a
href="tabs.html#method-query">chrome.tabs.query {‘windowId’: windowID}</a>.
On 2011/11/30 21:46:15, kathyw wrote:
> This isn't standard syntax. How about:
> 
> <a href="tabs.html#method-query">chrome.tabs.query()</a> with the argument
> <code>{‘windowId’: windowID}</code>.
> 
> also,  change the curly quote to straight quotes.

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:106: <a
href="tabs.html#method-query">chrome.tabs.query {‘active’: true}</a>.
On 2011/11/30 21:46:15, kathyw wrote:
> Same change as the previous one, perhaps without the link.

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:119: The “experimental”
permission is no longer required
On 2011/11/30 21:46:15, kathyw wrote:
> Change to straight quotes. We usually use straight quotes even where curly
> quotes might be correct.

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:121: <a
href="windows.html#type-Window">window “panel”</a> type.
On 2011/11/30 21:46:15, kathyw wrote:
> Again, change to straight quotes.

Done.

http://codereview.chromium.org/8743020/diff/2001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:122: By default, the “panel’
type creates a popup
On 2011/11/30 21:46:15, kathyw wrote:
> change to straight double-quotes.
> 
> (currently, they're curly and mismatched)

Done.

[kathyw, 2011-12-01 18:45:08]

Only tiny nitty comments remain. (This is really good enough to go, but I might
as well mention these.)

http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/static/whats_new.html (right):

http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:33: <li> The new
The new -> The

(globally in the "New APIs" section; sorry, didn't notice this before; we tend
to use "new" in other sections, but it's redundant in this one.)

http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:36: of navigation requests;

Not a big deal, but I'd probably just use two sentences (with a full stop
between them) instead of a semicolon.

http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:46: on a per-site basis
instead of globally;

same semicolon to full stop comment as above

[mkearney, 2011-12-06 19:03:44]

I've made the small changes below.

I have also added a proper link to the requirements section in the manifest doc.

And I added an updated version of the manifest doc with requirements content.

http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/static/whats_new.html (right):

http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:33: <li> The new
On 2011/12/01 18:45:08, kathyw wrote:
> The new -> The
> 
> (globally in the "New APIs" section; sorry, didn't notice this before; we tend
> to use "new" in other sections, but it's redundant in this one.)

Done.

http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:33: <li> The new
On 2011/12/01 18:45:08, kathyw wrote:
> The new -> The
> 
> (globally in the "New APIs" section; sorry, didn't notice this before; we tend
> to use "new" in other sections, but it's redundant in this one.)

Done.

http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:36: of navigation requests;
On 2011/12/01 18:45:08, kathyw wrote:
> 
> Not a big deal, but I'd probably just use two sentences (with a full stop
> between them) instead of a semicolon.

Done.

http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/whats_new.html:46: on a per-site basis
instead of globally;
On 2011/12/01 18:45:08, kathyw wrote:
> 
> same semicolon to full stop comment as above

Done.

[mihaip_google.com, 2011-12-07 02:52:34]

Replying by hand, since the Code Review too/App Engine is eating my
comments.

In whats_new.html, instead of:
For example, you can use this field to specify that your app requires "3D",
and that it supports two features, "css3d" and "webgl".

Can you say:
For example, you can use this field to specify that your app requires 3D
graphics support in order to use features such as CSS 3D Transforms or
WebGL.

Similarly in manifest.html, instead of:
Technologies required by the app or extension. Currently used only by the
Chrome Web Store, and only to specify "3D" requirements for "css3d" and
"webgl" as demonstrated in the following example:
<example>
The "css3d" requirement refers to the _CSS 3D Transforms specification_.
For more information on "3D" requirements, see the help article on _WebGL
and 3D graphics_. Support for additional requirements checks may be added
in the future.

Use:
Technologies required by the app or extension. Hosting sites such as as the
Chrome Web Store may use this list to dissuade users from installing apps
or extensions that will not work on their computer.

The only supported requirement is "3D", which denotes GPU hardware
acceleration. For that requirement, you can list that what 3D-related
features your app requires, as demonstrated in the following example:
<example>
The "css3d" requirement refers to the _CSS 3D Transforms specification_,
and the "webgl" requirement refers to the <a href="
http://www.khronos.org/webgl/">WebGL API</a>. For more information on
Chrome 3D graphics support, see the help article on _WebGL and 3D
graphics_. Support for additional requirements checks may be added in the
future.

Mihai

On Tue, Dec 6, 2011 at 11:03 AM, <mkearney@google.com> wrote:

> I've made the small changes below.
>
> I have also added a proper link to the requirements section in the
> manifest doc.
>
> And I added an updated version of the manifest doc with requirements
> content.
>
>
>
> http://codereview.chromium.**org/8743020/diff/8001/chrome/**
>
common/extensions/docs/static/**whats_new.html<http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/docs/static/whats_new.html>
> File chrome/common/extensions/docs/**static/whats_new.html (right):
>
> http://codereview.chromium.**org/8743020/diff/8001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode33<http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/docs/static/whats_new.html#newcode33>
> chrome/common/extensions/docs/**static/whats_new.html:33: <li> The new
> On 2011/12/01 18:45:08, kathyw wrote:
>
>> The new -> The
>>
>
>  (globally in the "New APIs" section; sorry, didn't notice this before;
>>
> we tend
>
>> to use "new" in other sections, but it's redundant in this one.)
>>
>
> Done.
>
>
> http://codereview.chromium.**org/8743020/diff/8001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode33<http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/docs/static/whats_new.html#newcode33>
> chrome/common/extensions/docs/**static/whats_new.html:33: <li> The new
> On 2011/12/01 18:45:08, kathyw wrote:
>
>> The new -> The
>>
>
>  (globally in the "New APIs" section; sorry, didn't notice this before;
>>
> we tend
>
>> to use "new" in other sections, but it's redundant in this one.)
>>
>
> Done.
>
>
> http://codereview.chromium.**org/8743020/diff/8001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode36<http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/docs/static/whats_new.html#newcode36>
> chrome/common/extensions/docs/**static/whats_new.html:36: of navigation
> requests;
> On 2011/12/01 18:45:08, kathyw wrote:
>
>  Not a big deal, but I'd probably just use two sentences (with a full
>>
> stop
>
>> between them) instead of a semicolon.
>>
>
> Done.
>
>
> http://codereview.chromium.**org/8743020/diff/8001/chrome/**
>
common/extensions/docs/static/**whats_new.html#newcode46<http://codereview.chromium.org/8743020/diff/8001/chrome/common/extensions/docs/static/whats_new.html#newcode46>
> chrome/common/extensions/docs/**static/whats_new.html:46: on a per-site
> basis instead of globally;
> On 2011/12/01 18:45:08, kathyw wrote:
>
>  same semicolon to full stop comment as above
>>
>
> Done.
>
>
http://codereview.chromium.**org/8743020/<http://codereview.chromium.org/8743...
>

[mkearney, 2011-12-09 00:04:38]

Fingers crossed these are ready for public consumption.

[kathyw, 2011-12-09 01:45:28]

Aside from a couple of capitalization issues, looks good to me.

http://codereview.chromium.org/8743020/diff/26001/chrome/common/extensions/do...
File chrome/common/extensions/docs/static/whats_new.html (right):

http://codereview.chromium.org/8743020/diff/26001/chrome/common/extensions/do...
chrome/common/extensions/docs/static/whats_new.html:77: now has an
<code>updateURL</code> property.

This is capitalized differently in the linked-to docs (updateURL vs. updateUrl),
which might cause problems.

http://codereview.chromium.org/8743020/diff/26001/chrome/common/extensions/do...
chrome/common/extensions/docs/static/whats_new.html:99: to specify the
<code>tabID</code> for the

Again, this is capitalized differently in the linked-to docs (tabID vs. tabId).
This might be confusing.

[Mihai Parparita -not on Chrome, 2011-12-09 03:05:46]

LGTM

[Mike West, 2011-12-12 17:33:21]

lgtm

Throwing this into the queue.

[commit-bot: I haz the power, 2011-12-12 17:33:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkearney@google.com/8743020/30001

[commit-bot: I haz the power, 2011-12-12 17:33:34]

Presubmit check for 8743020-30001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
(Report problems to tessamac@chromium.org.)
 - Changes to chrome/common/extensions/docs/static/manifest.html not reflected
in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py

Presubmit checks took 2.0s to calculate.

[Mike West, 2011-12-12 17:47:35]

lgtm

Trying again, with all the docs uploaded. :)

[commit-bot: I haz the power, 2011-12-12 17:47:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkearney@google.com/8743020/35001

[commit-bot: I haz the power, 2011-12-12 19:18:52]

Change committed as 114051

[mihaip_google.com, 2011-12-15 22:41:37]

Is this going to get merged into the 912 (Chrome 16) branch?

Mihai

On Mon, Dec 12, 2011 at 11:18 AM, <commit-bot@chromium.org> wrote:

> Change committed as 114051
>
>
http://codereview.chromium.**org/8743020/<http://codereview.chromium.org/8743...
>