Issue 8743007: Enable GAIA profile info downloader by default

Issue 8743007: Enable GAIA profile info downloader by default (Closed)

Created:
9 years ago by sail

Modified:
9 years ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable GAIA profile info downloader by default BUG=91241 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112368

Patch Set 2 : address review comments #

Patch Set 3 : fix test #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -14 lines)			Patch
M	chrome/browser/profiles/gaia_info_update_service.cc	View	1	3 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/profiles/gaia_info_update_service_unittest.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

lgtm http://codereview.chromium.org/8743007/diff/1/chrome/browser/profiles/gaia_info_update_service.cc File chrome/browser/profiles/gaia_info_update_service.cc (right): http://codereview.chromium.org/8743007/diff/1/chrome/browser/profiles/gaia_info_update_service.cc#newcode7 chrome/browser/profiles/gaia_info_update_service.cc:7: #include "base/command_line.h" nit: remove this too

9 years ago (2011-11-30 17:50:36 UTC) #2

sail

http://codereview.chromium.org/8743007/diff/1/chrome/browser/profiles/gaia_info_update_service.cc File chrome/browser/profiles/gaia_info_update_service.cc (right): http://codereview.chromium.org/8743007/diff/1/chrome/browser/profiles/gaia_info_update_service.cc#newcode7 chrome/browser/profiles/gaia_info_update_service.cc:7: #include "base/command_line.h" On 2011/11/30 17:50:36, rsesek wrote: > nit: ...

9 years ago (2011-11-30 19:03:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8743007/3001

9 years ago (2011-11-30 19:07:43 UTC) #5

commit-bot: I haz the power

Try job failure for 8743007-3001 (retry) on win_rel for step "unit_tests". It's a second try, ...

9 years ago (2011-11-30 20:41:50 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8743007/4004

9 years ago (2011-11-30 21:20:49 UTC) #7

Change committed as 112368

Expand Messages | Collapse Messages