Issue 8743005: Add IME/keyboard WebUI files to 'textinput_chromeos'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8743005: Add IME/keyboard WebUI files to 'textinput_chromeos'. (Closed)

Created:
9 years ago by Yusuke Sato

Modified:
9 years ago

Reviewers:
mazda, Nirnimesh

CC:
chromium-reviews, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add IME/keyboard WebUI files to 'textinput_chromeos'. BUG=None TEST=ran depot_tools/watchlists.py TBR=nirnimesh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112167

Patch Set 2 : untabify #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	WATCHLISTS	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

mazda: Please let me know if you know other files that are relevant to 'textinput_chromeos'.

9 years ago (2011-11-30 07:16:35 UTC) #1

mazda

LGTM I think the list looks fine. http://codereview.chromium.org/8743005/diff/1/WATCHLISTS File WATCHLISTS (right): http://codereview.chromium.org/8743005/diff/1/WATCHLISTS#newcode307 WATCHLISTS:307: 'chromeos/.*(language|keyboard).*'\ Remove ...

9 years ago (2011-11-30 07:22:40 UTC) #2

Yusuke Sato

http://codereview.chromium.org/8743005/diff/1/WATCHLISTS File WATCHLISTS (right): http://codereview.chromium.org/8743005/diff/1/WATCHLISTS#newcode307 WATCHLISTS:307: 'chromeos/.*(language|keyboard).*'\ On 2011/11/30 07:22:40, mazda wrote: > Remove tabs? ...

9 years ago (2011-11-30 07:25:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8743005/4001

9 years ago (2011-11-30 07:25:53 UTC) #4

Change committed as 112167

Expand Messages | Collapse Messages

Issue 8743005: Add IME/keyboard WebUI files to 'textinput_chromeos'. (Closed)

Description

Patch Set 1 #

Patch Set 2 : untabify #

Messages