Issue 8743001: IndexedDB: Add support for IDBIndex multientry flag

Issue 8743001: IndexedDB: Add support for IDBIndex multientry flag (Closed)

Created:
9 years ago by jsbell

Modified:
9 years ago

Reviewers:
hans, darin (slow to review), jam, dgrogan, brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

IndexedDB: Add support for IDBIndex multientry flag WebKit side (which needs to land first) is: https://bugs.webkit.org/show_bug.cgi?id=73232 which landed as WebKit r101602 BUG=103578 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112777

Patch Set 1 #

Patch Set 2 : rename multientry->multiEntry #

Total comments: 5

Patch Set 3 : address style nits #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
M	content/browser/in_process_webkit/indexed_db_dispatcher_host.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/indexed_db_messages.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_webidbobjectstore_impl.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/renderer_webidbobjectstore_impl.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jsbell

On 2011/11/30 12:09:58, hans wrote: > LGTM darin@ or jam@ - OWNERS review for content/renderer ...

9 years ago (2011-12-02 17:09:11 UTC) #2

jam

9 years ago (2011-12-02 20:36:04 UTC) #3

lgtm with nit

http://codereview.chromium.org/8743001/diff/3001/content/browser/in_process_w...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/8743001/diff/3001/content/browser/in_process_w...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:800:
params.name, params.key_path, params.unique, params.multiEntry,
multi_entry

http://codereview.chromium.org/8743001/diff/3001/content/common/indexed_db_me...
File content/common/indexed_db_messages.h (right):

http://codereview.chromium.org/8743001/diff/3001/content/common/indexed_db_me...
content/common/indexed_db_messages.h:110: IPC_STRUCT_MEMBER(bool, multiEntry)
multi_entry

http://codereview.chromium.org/8743001/diff/3001/content/renderer/renderer_we...
File content/renderer/renderer_webidbobjectstore_impl.cc (right):

http://codereview.chromium.org/8743001/diff/3001/content/renderer/renderer_we...
content/renderer/renderer_webidbobjectstore_impl.cc:122: bool multiEntry,
ditto

http://codereview.chromium.org/8743001/diff/3001/content/renderer/renderer_we...
content/renderer/renderer_webidbobjectstore_impl.cc:129: params.multiEntry =
multiEntry;
ditto

http://codereview.chromium.org/8743001/diff/3001/content/renderer/renderer_we...
File content/renderer/renderer_webidbobjectstore_impl.h (right):

http://codereview.chromium.org/8743001/diff/3001/content/renderer/renderer_we...
content/renderer/renderer_webidbobjectstore_impl.h:53: bool multiEntry,
nit: multi_entry per chrome style guide

Expand Messages | Collapse Messages