Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 8742026: Pepper: Add a test for PPB_AudioConfig failure cases. (Closed)

Created:
9 years ago by viettrungluu
Modified:
9 years ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Pepper: Add a test for PPB_AudioConfig failure cases. Also rename "Everything" to "ValidConfigs" and update the (Mac) Valgrind exclusion. And preemptively add an exclusion for the new test. :( Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -13 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/tests/test_audio_config.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/tests/test_audio_config.cc View 2 chunks +32 lines, -2 lines 0 comments Download
M tools/valgrind/gtest_exclude/ui_tests.gtest_mac.txt View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
9 years ago (2011-11-30 19:29:20 UTC) #1
piman
lgtm
9 years ago (2011-11-30 22:00:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8742026/1
9 years ago (2011-11-30 22:16:33 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-01 00:40:54 UTC) #4
Change committed as 112356

Powered by Google App Engine
This is Rietveld 408576698