Issue 8742012: MIPS: Catch non-string subject in RegExpExecStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8742012: MIPS: Catch non-string subject in RegExpExecStub. (Closed)

Created:
9 years ago by kalmard

Modified:
9 years ago

Reviewers:
kisg, Paul Lind, Yang, danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Catch non-string subject in RegExpExecStub. Port r10064 (9c6789a3) Original commit message: There is no test case to trigger any crash. This is only to guard against the case that the native function is called with unsafe arguments. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10097

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/mips/code-stubs-mips.cc	View		3 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kalmard

Fully building and testing v8 on MIPS requires the following patches to be landed: http://codereview.chromium.org/8561001/ ...

9 years ago (2011-11-30 13:59:12 UTC) #1

Yang

9 years ago (2011-11-30 16:34:47 UTC) #2

On 2011/11/30 13:59:12, kalmard wrote:
> Fully building and testing v8 on MIPS requires the following patches to be
> landed:
> 
> http://codereview.chromium.org/8561001/
> http://codereview.chromium.org/8743010/
> http://codereview.chromium.org/8744012/
> http://codereview.chromium.org/8743009/
> http://codereview.chromium.org/8742012/
> http://codereview.chromium.org/8745012/
> http://codereview.chromium.org/8746015/
> http://codereview.chromium.org/8747011/

LGTM. Landing.

Expand Messages | Collapse Messages